CR_FILTER=only_subtests|i_want|etc ./tests.sh -R e2e_logging#7870
Open
CR_FILTER=only_subtests|i_want|etc ./tests.sh -R e2e_logging#7870
Conversation
Agent-Logs-Url: https://github.com/microsoft/CCF/sessions/df5f100b-506c-4d2b-8254-35fc923c846f Co-authored-by: maxtropets <16566519+maxtropets@users.noreply.github.com>
Agent-Logs-Url: https://github.com/microsoft/CCF/sessions/df5f100b-506c-4d2b-8254-35fc923c846f Co-authored-by: maxtropets <16566519+maxtropets@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
maxtropets
May 8, 2026 12:38
View session
Agent-Logs-Url: https://github.com/microsoft/CCF/sessions/46ef3b41-07de-4097-abfb-3958ed01ddbe Co-authored-by: maxtropets <16566519+maxtropets@users.noreply.github.com>
maxtropets
changed the title
maxtropets
changed the title
Contributor
There was a problem hiding this comment.
Pull request overview
Adds an opt-in environment-variable based filter to the Python e2e ConcurrentRunner so developers can run only specific sub-tests by exact name match, without relying on regex matching.
Changes:
- Introduces
CR_FILTERparsing (pipe-separated names) to control which sub-tests are added. - Skips adding sub-tests in
ConcurrentRunner.add()when their name does not exactly match the filter entries.
Custom instructions used:
.github/copilot-instructions.md.github/instructions/reviewing.instructions.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tested locally, works as expected
Now one can run
CR_FILTER=cpp ./tests.sh -R e2e_logging_http2, orCR_FILTER="cpp|js", for instance.This avoids commenting out huge blocks on the bottom which then make it to the review, and sometimes even merged in in pre-copilot era, so I mainly did for convenience.
tests.sh, ctest, andConcurrentRunner(tests/infra/runner.py)CR_FILTERenv var support inConcurrentRunner.addto skip non-matching subtests by exact name (e.g.CR_FILTER="testname1|testname2")listwithincheck (per reviewer request)testname2_suffixis excluded for filtertestname2