Simplify standalone AL code review skill - #150
Simplify standalone AL code review skill#150Jesper Schulz-Wedde (JesperSchulz) merged 2 commits into
Conversation
|
Pushed 87da853 to this branch covering two gaps in the delegation. Both come from the same root cause: 1. Index preparation never ran under a plugin install. The fix keeps the adapter thin, since path translation is precisely an adapter's job: step 3 now resolves Entry's repo-relative paths against 2. The layer-pruning caveat was deleted rather than relocated. The old adapter warned that a plugin ships the whole tree, so Entry now scopes the guarantee to consumers that actually prune and states plainly that an unpruned installation gets no deny guarantee from the step. The full caveat is restored in the adapter and summarized in the README plugin section. Heads-up on approvals: this touches The rest of the PR stands: thinning the adapter is the right call, Note this branch is still based on 35a7e72 and is behind |
Rename the host-facing skill to al-code-review, reduce it to a thin Entry adapter, document the architecture, and validate host skill metadata. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: af96bb3d-893a-48a2-8298-c8f4271c162c
The adapter delegated index preparation to Entry's Preparation step, but that step is written for the clone model: it runs `pwsh ./tools/Build-KnowledgeIndex.ps1` from the checkout root. A plugin host's working directory is the user's own project, so the path does not resolve and the index is never built. Because knowledge-index.json is gitignored, a fresh install has none, and READ silently degrades to path-based discovery. The adapter now resolves Entry's repo-relative paths against PLUGIN_ROOT and names the absolute index build; the generator resolves its own root, so it indexes and writes the right tree from any cwd. Entry also asserted that pruning has always happened before it runs, which is false for an installation that ships the whole tree. Entry now scopes that guarantee to consumers that actually prune, and the caveat dropped in the rewrite - that enabled-layers narrows discovery rather than denying access - is restored in the adapter and summarized in the README. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 0b67b90d-e4b4-4b92-9684-726c72c43b3f
87da853 to
045f4bc
Compare
Summary
bcquality-al-reviewtoal-code-review.SKILL.mdto a thin adapter that preserves the caller's goal and delegates index preparation, routing, execution, and output semantics to Entry and the dispatched action skills.skills/directory and bump the plugin version to0.2.0.microsoft/skills/review/al-code-review.mdcoordinator, and its domain leaves.Rationale
Standalone installation still requires a host-native
SKILL.md, but it should not become a second review implementation. The adapter now owns only translation into Entry's task context. The remaining reference chain is intentional progressive disclosure rather than duplicated policy.al-code-reviewalso avoids colliding with BC-ALAgents' separately installedal-reviewskill while using the same semantic name as BCQuality's internal coordinator. Their paths and formats distinguish their roles.Migration
Explicit invocations and allowlists using
bcquality-al-reviewmust useal-code-reviewafter updating to plugin version0.2.0.Validation
python .github/scripts/validate_frontmatter.py --root .pwsh -NoProfile -File tools/Test-ReviewFixtures.ps1al-code-reviewand BC-ALAgentsal-reviewpresent