Fix: DownloadRelease incorrectly matches release assets from projects with the same name prefix#2311
Draft
spetersenms with Copilot wants to merge 2 commits into
Draft
Fix: DownloadRelease incorrectly matches release assets from projects with the same name prefix#2311spetersenms with Copilot wants to merge 2 commits into
spetersenms with Copilot wants to merge 2 commits into
Conversation
… matches for projects with same name prefix
Copilot
AI
changed the title
[WIP] Fix issue with locating release assets for similar project names
Fix: DownloadRelease incorrectly matches release assets from projects with the same name prefix
Jul 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When locating previous release assets, the glob pattern
logis-interface-*-Apps-*.zipmatched assets fromlogis-interface-2-core-librarybecause*spans hyphens. This caused unrelated projects' apps to be used as the previous release baseline.Fix
DownloadReleaseinActions/Github-Helper.psm1already uses regex patterns with[^-]+for the branch segment instead of glob wildcards:[^-]+prevents the branch segment from spanning hyphen-separated project name components, sologis-interface-[^-]+-Apps-.+\.zip$correctly rejectslogis-interface-2-core-library-main-Apps-1.0.64.0.zip.Tests
Added regression tests in
Tests/GitHub-Helper.Test.ps1covering:logis-interfacedownloads only its own assets, notlogis-interface-2-core-libraryassets (the reported scenario)logis-interface-2-core-libraryresolves its own assets independently*project still matches all assets✅ Checklist