Add evaluate_best_model option to skip final RMSE/MAE evaluation in mtt train#1192
Draft
zyxwwxyz wants to merge 2 commits into
Draft
Add evaluate_best_model option to skip final RMSE/MAE evaluation in mtt train#1192zyxwwxyz wants to merge 2 commits into
evaluate_best_model option to skip final RMSE/MAE evaluation in mtt train#1192zyxwwxyz wants to merge 2 commits into
Conversation
Contributor
|
Thanks! The fact that is the best model is a choice by each architecture. All we do is to export the model (here most architectures choose to export the best model) and evaluate it. Could you reword to capture this? Maybe the input is better called |
Contributor
|
Perfect, I would say this is good to go 👍 We will merge #1189 first and then come to this one. The hyper will need to be moved to the new doc section introduced in that PR. (right now everything is blocked because CSCS is not available to run the tests) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
evaluate_best_modelboolean to themtt trainYAML input (defaulttrue), following the pattern proposed in Add the possibility to avoid printing stats #1189 forprint_stats.evaluate_best_modeltofalseand subsequently runningmtt evalon the training, validation and test sets, metrics are evaluated and predicted labels are printed in a resource efficient way.false,mtt trainskips reloading and evaluating the best model (the one exported to.pt) on the training, validation and test sets after training, avoiding the RMSE/MAE computation. Training, checkpointing and model export are unaffected.📚 Documentation preview 📚: https://metatrain--1192.org.readthedocs.build/en/1192/