Refactor withSpinner to accept a callback with spinner control and dynamic success/failure messages - #20
Merged
adelrodriguez merged 1 commit intoAug 6, 2026
Conversation
Collaborator
Author
This was referenced Aug 5, 2026
adelrodriguez
marked this pull request as ready for review
August 5, 2026 23:35
Collaborator
Author
|
@codex review |
|
Codex Review: Didn't find any major issues. 👍 Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
adelrodriguez
changed the base branch from
08-05-implement_clean_command_with_local_project_clean_and_--global_store_wipe
to
graphite-base/20
August 6, 2026 02:25
adelrodriguez
force-pushed
the
08-05-refactor_withspinner_to_accept_a_callback_and_rename_spinner_message_options
branch
from
August 6, 2026 02:33
26a9462 to
aa66d42
Compare
adelrodriguez
force-pushed
the
graphite-base/20
branch
from
August 6, 2026 02:33
1e8e037 to
3c2de5e
Compare
adelrodriguez
force-pushed
the
08-05-refactor_withspinner_to_accept_a_callback_and_rename_spinner_message_options
branch
from
August 6, 2026 02:39
aa66d42 to
4120159
Compare
adelrodriguez
deleted the
08-05-refactor_withspinner_to_accept_a_callback_and_rename_spinner_message_options
branch
August 6, 2026 02:40
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Refactor
withSpinnerto support dynamic messages and mid-spin updatesThe
withSpinnerAPI onPrompterhas been redesigned to be more flexible and expressive:runargument is now a callback that receives a spinner control object, allowing callers to update the spinner message mid-operation viaspinner.message(...). This is used inaddPackageCandidateto display a "Fetching and materializing" message after the resolution step completes.successoption now accepts either a static string or a function that receives the operation's return value, enabling result-aware completion messages (e.g. showing the resolved package identity, or distinguishing between"missing"and"malformed"tsconfig/AGENTS.md outcomes).erroroption has been renamed tofailureand made optional. When omitted, the spinner stops without a message on failure.Effect.acquireUseReleaseinstead ofEffect.onExit, ensuring the spinner is always stopped even on interruption.addPackageCandidateReferencehas been split intoresolvePackageCandidateReferenceandmaterializePackageCandidateReferenceto allow the spinner message to be updated between the two phases.withSpinnercovering success, failure, interruption, and omitted failure message cases.