revert(create-melonjs): drop --template flag#1441
Merged
Conversation
Walked back the `--template <name>` / `-t` flag and the related 1.0.1 → 1.1.0 version bump. Aligns with how the other plugins (`@melonjs/spine-plugin`, `@melonjs/tiled-inflate-plugin`, `@melonjs/debug-plugin`) work today: users scaffold the default boilerplate and `npm install` the plugin themselves. The Capacitor wiki page documents the manual steps. This avoids: - Maintaining a separate `typescript-boilerplate-capacitor` repo (or a subfolder of the existing one). - Coupling create-melonjs to the boilerplate's source layout via string/AST patches. Net: `bin/create-melonjs.js` back to 99 lines (no flag parsing), `package.json` version stays at 1.0.1, README templates table removed, and the 1.1.0 CHANGELOG entry deleted (it was never published). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR reverts the recently added --template/-t support in create-melonjs, returning the scaffolder to always using the default melonjs/typescript-boilerplate flow (with optional plugins installed manually afterward). This aligns create-melonjs with the existing plugin ecosystem approach.
Changes:
- Removed the templates section from
create-melonjsREADME. - Removed the
1.1.0changelog entry describing template support. - Simplified
bin/create-melonjs.jsto stop parsing--template/-tand always scaffold from the default boilerplate; package version set back to1.0.1.
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/create-melonjs/README.md | Removes documentation for the --template feature and template table. |
| packages/create-melonjs/package.json | Reverts package version back to 1.0.1. |
| packages/create-melonjs/CHANGELOG.md | Removes the 1.1.0 entry that documented template support. |
| packages/create-melonjs/bin/create-melonjs.js | Drops template flag parsing and always uses the default boilerplate repo. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Walks back the
--template <name>/-tflag added tocreate-melonjsin #1439. Aligns with how the other plugins (@melonjs/spine-plugin,@melonjs/tiled-inflate-plugin,@melonjs/debug-plugin) work today — users scaffold the default boilerplate andnpm installthe plugin themselves.The Capacitor wiki page (draft at
/tmp/Capacitor.md) documents the manual steps. No new boilerplate repo or subfolder needed.Why revert
Two undesirable downstream costs of the flag:
typescript-boilerplate-capacitorrepo (drift on every melonJS /@melonjs/*bump) or acapacitor/subfolder of the existing repo (cleaner but still extra surface).create-melonjsto the boilerplate's source layout (regex/AST edits tosrc/main.ts,package.jsonmerges, etc.).Neither is worth it. The Capacitor plugin is just
npm install+ a singleplugin.register(...)call, same as the existing plugins.Files
packages/create-melonjs/bin/create-melonjs.js— back to 99 lines, no flag parsing.packages/create-melonjs/package.json— version stays at 1.0.1 (the 1.1.0 bump was never published).packages/create-melonjs/CHANGELOG.md— 1.1.0 entry removed.packages/create-melonjs/README.md— templates table removed.The
@melonjs/capacitor-pluginpackage itself is unaffected; this iscreate-melonjs-only.Test plan
pnpm lint— 0 errors.node bin/create-melonjs.js— usage banner is back to the original (no--templatemention).🤖 Generated with Claude Code