Skip to content

MSVC Unreachable Code Warning on /W4 #307

Description

@KKhanhH

Environment

FetchContent_Declare(
tomlplusplus
GIT_REPOSITORY https://github.com/marzer/tomlplusplus.git
GIT_TAG v3.4.0
SYSTEM
EXCLUDE_FROM_ALL
)

Compiler:
MSVC Version 19.51.36248

C++ standard mode:
C++20

Target arch:
x64

Relevant compilation flags:
/WX /W4 /external:anglebrackets /external:W0
(the external ones have no effect)

Describe the bug

There is a compiler warning in parser.inl that causes will break builds with warnings as errors enabled on MSVC. This is one of the warnings that MSVC's /external flags won't work on, so the only way I can suppress this warning is by disabling it in my executable which is not a nice experience.

[build] <BUILD_FOLDER>\_deps\tomlplusplus-src\include\toml++\impl\parser.inl(2775) : error C2220: the following warning is treated as an error
[build] <BUILD_FOLDER>\_deps\tomlplusplus-src\include\toml++\impl\parser.inl(2775) : warning C4702: unreachable code
[build] <BUILD_FOLDER>\_deps\tomlplusplus-src\include\toml++\impl\parser.inl(2962) : warning C4702: unreachable code

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

bugSomething isn't working

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions