Change Application.cfc method "onApplicationStop" to "onApplicationEnd" in examples#4
Open
jjannek wants to merge 1 commit into
Open
Change Application.cfc method "onApplicationStop" to "onApplicationEnd" in examples#4jjannek wants to merge 1 commit into
jjannek wants to merge 1 commit into
Conversation
Owner
|
Hey @jjannek I appreciate the pull request. Before I merge it I want to ensure all the existing tests pass, and to do that I need to get a proper CF environment set up again, which might take me a few days since I'm travelling. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The ACF/Railo/Lucee internal Application.cfc function is called onApplicationEnd instead of onApplicationStop. I suggest to use it.
This way there are also no errors if calling the method manually after applicationStop() during a re-init or manual stop of the example apps. There is no manual call of the method required.
Reference: https://wikidocs.adobe.com/wiki/display/coldfusionen/onApplicationEnd