Repository navigation
Conversation
… and alphaLabel props
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
The
ColorInputdropdown renders theColorPickersaturation, hue and alpha sliders withrole="slider", butColorInputdoes not acceptsaturationLabel,hueLabelandalphaLabel. The sliders therefore have no accessible name, and axe reportsaria-input-field-namefor them. The ColorPicker docs already recommend these props for screen readers, but there is no way to set them throughColorInput.Fix
Move
saturationLabel,hueLabelandalphaLabelfromColorPickerPropsto__ColorPickerProps, the propsColorInputshares withColorPicker, and pass them fromColorInputtoColorPicker. This follows the approachfullWidthtook in #9061. TheColorPickerAPI does not change.The ColorInput docs page gets a short note with an example after the accessibility section, in the same form as the clear button note on the Select page.
Testing
ColorInput.test.tsx:passes slider labels to ColorPickeropens the dropdown withformat="rgba"and looks up all three sliders by name. It fails on master (no slider namedtest-saturation) and passes with the fix.ColorInputandColorPickersuites: 116 passed.npm testpasses. The only failure in the full run wasTour.test.tsx(animates the tooltip position only while moving to another step target), which passes when run on its own and does not touch these components.