Skip to content

[@mantine/core] ColorInput: Add support for saturationLabel, hueLabel and alphaLabel props - #9389

Open
kammeph wants to merge 1 commit into
mantinedev:masterfrom
kammeph:fix/color-input-slider-labels
Open

kammeph wants to merge 1 commit into
mantinedev:masterfrom
kammeph:fix/color-input-slider-labels

Conversation

@kammeph

@kammeph kammeph commented Nov 6, 2026

Copy link
Copy Markdown

Bug

The ColorInput dropdown renders the ColorPicker saturation, hue and alpha sliders with role="slider", but ColorInput does not accept saturationLabel, hueLabel and alphaLabel. The sliders therefore have no accessible name, and axe reports aria-input-field-name for them. The ColorPicker docs already recommend these props for screen readers, but there is no way to set them through ColorInput.

Fix

Move saturationLabel, hueLabel and alphaLabel from ColorPickerProps to __ColorPickerProps, the props ColorInput shares with ColorPicker, and pass them from ColorInput to ColorPicker. This follows the approach fullWidth took in #9061. The ColorPicker API does not change.

The ColorInput docs page gets a short note with an example after the accessibility section, in the same form as the clear button note on the Select page.

Testing

  • ColorInput.test.tsx: passes slider labels to ColorPicker opens the dropdown with format="rgba" and looks up all three sliders by name. It fails on master (no slider named test-saturation) and passes with the fix.
  • ColorInput and ColorPicker suites: 116 passed.
  • npm test passes. The only failure in the full run was Tour.test.tsx (animates the tooltip position only while moving to another step target), which passes when run on its own and does not touch these components.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 6, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-06T12:56:40.617598Z 67aee69 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@rtivital rtivital added the ? label Nov 10, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants