Skip to content

⚡ perf: cache carrier instances in getGroupedAllShippingRates()#40733

Open
lbajsarowicz wants to merge 1 commit intomagento:2.4-developfrom
lbajsarowicz:perf/quote-cache-carrier-factory
Open

⚡ perf: cache carrier instances in getGroupedAllShippingRates()#40733
lbajsarowicz wants to merge 1 commit intomagento:2.4-developfrom
lbajsarowicz:perf/quote-cache-carrier-factory

Conversation

@lbajsarowicz
Copy link
Copy Markdown
Contributor

Summary

  • Cache carrier instances by carrier code in Quote\Address::getGroupedAllShippingRates() to avoid redundant carrierFactory->get() calls.
  • Previously, carrierFactory->get() was called twice per shipping rate (once for sorting, once for title). With N rates across M carriers, this caused 2N factory calls instead of M.

Performance Impact

Metric Before After
carrierFactory->get() calls 2× per rate 1× per unique carrier code
Scope Method-local cache, no stale-object risk Same

Test Plan

  • Unit test verifies carrierFactory->get() called once per unique carrier code
  • Test uses 3 rates (2 flatrate, 1 tablerate) asserting exactly 2 factory calls
  • PHPCS clean (requires CI)
  • PHPStan clean (requires CI)

Ref: #40702

⭐ Support my work

Do you like the fix? Remember to react with "👍🏻" to get it merged faster,
Then Sponsor me on Github so I can spend more time on fixing issues like this one.

Learn more at https://github.com/sponsors/lbajsarowicz

Avoid redundant carrierFactory->get() calls for the same carrier code
when grouping shipping rates by carrier.

Ref: magento#40702
@m2-assistant
Copy link
Copy Markdown

m2-assistant Bot commented Apr 13, 2026

Hi @lbajsarowicz. Thank you for your contribution!
Here are some useful tips on how you can test your changes using Magento test environment.
❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names.

Allowed build names are:
  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here
ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.


For more details, review the Code Contributions documentation.
Join Magento Community Engineering Slack and ask your questions in #github channel.

@lbajsarowicz
Copy link
Copy Markdown
Contributor Author

@magento run all tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Priority: P3 May be fixed according to the position in the backlog. Progress: pending review

Projects

Status: Pending Review

Development

Successfully merging this pull request may close these issues.

2 participants