Colour-manage input via PCS for device-independent colourspaces - #4596
Open
mertalev wants to merge 1 commit into
Open
Colour-manage input via PCS for device-independent colourspaces#4596mertalev wants to merge 1 commit into
mertalev wants to merge 1 commit into
Conversation
mertalev
force-pushed
the
fix/linear-processing
branch
2 times, most recently
from
August 31, 2026 07:27
67554d2 to
cbe8835
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #4595 by importing input profiles through the ICC profile connection space when using a device-independent pipeline colourspace, as vips_thumbnail does in linear mode.
EnsureColourspaceis deferred until after it, andicc_exportbefore the output colourspace is applied, since converting to a device space first would gamut-clip.Also slightly relaxes shrink-on-load to be allowed if the conversion is deferred as such.This actually affects whether the resampling is linear, so deferring this for now. It could maybe be a separate PR that ties it tofastShrinkOnLoad.