nemo-preview: fix missing syntax highlighting in text previews#583
Open
Boccolarg wants to merge 1 commit into
Open
nemo-preview: fix missing syntax highlighting in text previews#583Boccolarg wants to merge 1 commit into
Boccolarg wants to merge 1 commit into
Conversation
GtkSourceView highlights only when the buffer has both a language and a resolvable style scheme. Neither was guaranteed: - No language was ever assigned to the loaded buffer. - The scheme name comes from the Xed editor settings, but the default StyleSchemeManager doesn't search the editor style dirs (<data dir>/xed/styles, <data dir>/gedit/styles), so user-installed schemes resolved to null and cleared all colors. Register those search paths, guess the language from the file name and content type, and skip applying an unresolved (null) scheme.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GtkSourceView highlights only when the buffer has both a language and a
resolvable style scheme. Neither was guaranteed:
StyleSchemeManager doesn't search the editor style dirs
(/xed/styles, /gedit/styles), so user-installed
schemes resolved to null and cleared all colors.
Register those search paths, guess the language from the file name and
content type, and skip applying an unresolved (null) scheme.