Skip to content

partitioning: settle udev and abort on mkfs failure in full_disk_format #184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ggiesen wants to merge 1 commit into
base: master
Choose a base branch
from
Open

partitioning: settle udev and abort on mkfs failure in full_disk_format #184

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion usr/lib/live-installer/partitioning.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -470,6 +470,10 @@ def full_disk_format(device, create_boot=False, create_swap=True):
partition_path = "%s%s%d" % (device.path, partition_prefix, partition_number)
num_tries = 0
while True:
# Each parted invocation triggers a partition-table rescan;
# udev briefly removes and recreates the device nodes. Wait
# for it to finish or mkfs can race a vanishing node.
os.system("udevadm settle 2>/dev/null")
if os.path.exists(partition_path):
break
if num_tries < 5:
Expand All @@ -481,7 +485,11 @@ def full_disk_format(device, create_boot=False, create_swap=True):
raise Exception(_("The partition %s could not be created. The installation will stop. Restart the computer and try again.") % partition_path)
mkfs = mkfs.format(partition_path)
print(mkfs)
os.system(mkfs)
if os.system(mkfs) != 0:
# A failed format must stop the installation here: if this is
# tolerated, mounting fails silently and the file copy lands
# in the live session's tmpfs until it fills up.
raise Exception(_("The partition %s could not be formatted. The installation will stop. Restart the computer and try again.") % partition_path)
start_mb += size_mb + 1
if installer.setup.gptonefi:
run_parted('set 1 boot on')
Expand Down