Skip to content

rpm_action.yml: Run all but release creation every time#494

Merged
henry2cox merged 1 commit into
linux-test-project:masterfrom
hartwork:rpm-action-run-more-every-time
Jul 6, 2026
Merged

rpm_action.yml: Run all but release creation every time#494
henry2cox merged 1 commit into
linux-test-project:masterfrom
hartwork:rpm-action-run-more-every-time

Conversation

@hartwork

@hartwork hartwork commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

Related to #488

This will make problems in all but the last step show earlier, and hence help with debugging and keeping the workflow healthy. The existing if: startsWith(github.ref, 'refs/tags/v') already guards release creation for non-tag and non-v-tag pushes.

CC @henry2cox

@hartwork hartwork changed the title rpm_action.yml: Run all but release creation every time rpm_action.yml: Run all but release creation every time Jul 6, 2026
@hartwork hartwork force-pushed the rpm-action-run-more-every-time branch from 1676b9c to 5b66cd9 Compare July 6, 2026 16:17
@hartwork

hartwork commented Jul 6, 2026

Copy link
Copy Markdown
Contributor Author

@henry2cox update: now rebased onto latest master to resolve conflicts after merge of #489.

@henry2cox

Copy link
Copy Markdown
Collaborator

Question: do you also think I should be able to just re-tag with v2.5 - and the release will be rebuilt, with all the expected content? Or delete the current release and tag and create new release?

@henry2cox henry2cox merged commit ae60b04 into linux-test-project:master Jul 6, 2026
6 checks passed
@hartwork

hartwork commented Jul 6, 2026

Copy link
Copy Markdown
Contributor Author

Question: do you also think I should be able to just re-tag with v2.5 - and the release will be rebuilt, with all the expected content? Or delete the current release and tag and create new release?

@henry2cox I have seen tag moves and re-releases bite downstreams in the past, so I would personally recommend against re-creating the Git tag and/or re-placing the artifacts under the same name for existing tag v2.5. I think personally I would:

  • Keep the old 2.5 release but…
    • Drop the "Release " prefix
    • Delete the two beta-named RPM artifacts (which results in a fine release, just without artifacts)
  • Bump versions to "2.5.1" everywhere in master (potentially via a pull request)
  • Push a new tag v2.5.1 and let the CI do the release creation

What do you think?

@hartwork hartwork deleted the rpm-action-run-more-every-time branch July 6, 2026 16:39
@henry2cox

Copy link
Copy Markdown
Collaborator

looks like I can just change the name of the asset.
Still doesn't contain the tarball - but perhaps that doesn't matter so much.

@hartwork

hartwork commented Jul 6, 2026

Copy link
Copy Markdown
Contributor Author

looks like I can just change the name of the asset.

@henry2cox did the "beta" go into the RPM artifact content? Then the rename alone could be trouble 🤔

@henry2cox

Copy link
Copy Markdown
Collaborator

Yeah..I think I broke it.
In view of the very low number of downloads so far - I think, just you :-)
I'm going to cheat and just delete the current version and try again.

@hartwork

hartwork commented Jul 6, 2026

Copy link
Copy Markdown
Contributor Author

@henry2cox I see a new release now at https://github.com/linux-test-project/lcov/releases/tag/v2.5 but with no artifacts (yet?) and a markdown syntax issue near "support llvm/22".

@henry2cox

Copy link
Copy Markdown
Collaborator

Yes...I think 'yet' - seems to take a couple of minutes to build.
and yeah - typo (fixed) Never try to do 3 unrelated things across 2 computes, simultaneously.

@henry2cox

Copy link
Copy Markdown
Collaborator

hmm. Or maybe not. Has been a few minutes - but no artifacts have appeared, yet.

@hartwork

hartwork commented Jul 6, 2026

Copy link
Copy Markdown
Contributor Author

@henry2cox I'm having trouble finding the related CI run for a Git tag at https://github.com/linux-test-project/lcov/actions . Is the current 2.5 release a result of CI?

@henry2cox

Copy link
Copy Markdown
Collaborator

Yes.

@hartwork

hartwork commented Jul 6, 2026

Copy link
Copy Markdown
Contributor Author

@henry2cox I only see https://github.com/linux-test-project/lcov/actions/runs/28754646970 of yesterday. How did you you re-run the CI for 2.5? I'm also wondering if re-running CI for 2.5 can produce anything but the previous incomplete results if the tag also controls the workflow files being checked out. Maybe we need a new v2.5.1 tag in any case.

@hartwork

hartwork commented Jul 6, 2026

Copy link
Copy Markdown
Contributor Author

@henry2cox is there a chance for adding a source tarball manually to 2.5 or to let CI create 2.5.1 with a source tarball? It would allow me to bump lcov in Gentoo and to potentially signal other distros to follow via the RSS feeds tied to https://repology.org/project/lcov/history . What do you think?

@henry2cox

Copy link
Copy Markdown
Collaborator

Nothing I tried so far has quite worked.
So next thing is to try to delete the release and the tag..and try again.
Updating the release after making a few changes - did not have the desired effect.

If that doesn't work, then I'll try a 2.5.1 hack.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants