fix: remove createworkloadcatalog endpoint#993
Open
dennisvankekem wants to merge 1 commit into
Open
Conversation
9 tasks
ferruhcihan
requested changes
May 13, 2026
| schema: | ||
| type: object | ||
|
|
||
| '/v1/helmChartContent': |
Collaborator
There was a problem hiding this comment.
This endpoint (and the related code) appears to be no longer needed and should be removed.
| const { cluster } = await this.getSettings(['cluster']) | ||
|
|
||
| try { | ||
| await sparseCloneChart( |
Collaborator
There was a problem hiding this comment.
The sparseCloneChart() function is no longer used in production code and is only referenced in workloadUtils.test.ts. It should be removed from both files.
The updateChartIconInYaml() and updateRbacForNewChart() functions, along with the chartRepo class, are only used by sparseCloneChart(). They and their related test code should be removed.
| return await fetchChartYaml(url) | ||
| } | ||
|
|
||
| async createWorkloadCatalog(body: NewHelmChartValues): Promise<boolean> { |
Collaborator
There was a problem hiding this comment.
The NewHelmChartValues interface is no longer used and should be removed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
console: linode/apl-console#788
api: #993