Spec for streaming inference#930
Draft
drewoldag wants to merge 3 commits into
Draft
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #930 +/- ##
==========================================
- Coverage 63.80% 63.49% -0.31%
==========================================
Files 74 75 +1
Lines 7689 7775 +86
==========================================
+ Hits 4906 4937 +31
- Misses 2783 2838 +55 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
d203164 to
d0fdac6
Compare
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR puts together a spec file for "streaming inference". The gist is that we could load the model into memory once and process batches of data as they arrive with the expectation that there are potentially large gaps between the batches arriving.
Two additional things worth calling out that aren't mentioned in the spec:
inferinto a special case ofinfer_streamingsuch thatinfersimply callsinfer_streamingunder the hood and provides all the data to it, like it normally would.