webapi: preload onload/onerror callback timing#2724
Merged
Conversation
Prior to adding support for preload/modulepreload, we'd just fire a dummy load event on the next tick. But now that we have proper handling for these, we should fire load (or error) when the file is loaded (or failed to load). Our artificial Frame._to_load becomes a bit more generic...it still supports synthetic loads (e.g. for images), but it also supports "error" event. ScriptManage and ScriptManagerBase now queue a load/error event when a preloaded script completed/errors.
krichprollsch
approved these changes
Jun 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on: #2693
Prior to adding support for preload/modulepreload, we'd just fire a dummy load event on the next tick. But now that we have proper handling for these, we should fire load (or error) when the file is loaded (or failed to load). Our artificial Frame._to_load becomes a bit more generic...it still supports synthetic loads (e.g. for images), but it also supports "error" event.
ScriptManage and ScriptManagerBase now queue a load/error event when a preloaded script completed/errors.