telemetry: send agent_replay mode on non-interactive usage#2644
Merged
Conversation
krichprollsch
force-pushed
the
agent-telemetry
branch
from
c54e002 to
2ddbd4e
Compare
krichprollsch
force-pushed
the
agent-telemetry
branch
from
2ddbd4e to
495d207
Compare
karlseguin
reviewed
Jun 4, 2026
Co-authored-by: Karl Seguin <karlseguin@users.noreply.github.com>
karlseguin
approved these changes
Jun 5, 2026
The model length is limited to 23 char in DB.
arrufat
reviewed
Jun 5, 2026
arrufat
approved these changes
Jun 5, 2026
|
@krichprollsch @karlseguin @arrufat This could potentially leak internal company model names and unreleased models. Given the difficulty in disabling telemetry within |
Member
Author
|
@gaby thanks for the feedback, but can you elaborate about why you said it's difficult to disable the telemetry? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduce an
interactive()func from Config which is sent to the telemetry.Use the
interactivefield inagentmode to send a customagent_replaymode to the telemetry.add a new
llmevent w/providerandmodel.Relates with https://github.com/lightpanda-io/telemetry/pull/40