Update bdk_wallet to v3.0.0 and refactor test helpers#907
Update bdk_wallet to v3.0.0 and refactor test helpers#907HARSHVARANDANI wants to merge 3 commits into
Conversation
|
I've assigned @tnull as a reviewer! |
|
🔔 1st Reminder Hey @tnull! This PR has been waiting for your review. |
|
🔔 2nd Reminder Hey @tnull! This PR has been waiting for your review. |
|
🔔 3rd Reminder Hey @tnull! This PR has been waiting for your review. |
Camillarhi
left a comment
Camillarhi
left a comment
There was a problem hiding this comment.
Thanks for looking into this. Left a comment, and also a minor typo in the second commit message ("teh" → "the").
| Ok(address_info.address) | ||
| } | ||
|
|
||
| pub(crate) fn cancel_tx(&self, tx: &Transaction) -> Result<(), Error> { |
There was a problem hiding this comment.
Perhaps cancel_tx should be renamed here as well, BDK removed it because the name was misleading since it doesn't actually cancel anything, it just unmarks unused addresses, and the same reasoning should apply to this.
3 participants
Closes #776
Updated to using bdk_wallet v3.0.0 which supports the api for wallet events and removed the copied code for the same being used earlier