Skip to content

FLE-346: Remove lo tasks create-foundation-xml-import (breaking) - #253

Merged
RyanRatcliff merged 1 commit into
masterfrom
FLE-346-remove-foundation-xml-import
Mar 26, 2026
Merged

RyanRatcliff merged 1 commit into
masterfrom
FLE-346-remove-foundation-xml-import

Conversation

@RyanRatcliff

@RyanRatcliff RyanRatcliff commented Mar 26, 2026

Copy link
Copy Markdown
Contributor

Jira

FLE-346

Related

Summary

  • Delete lo tasks create-foundation-xml-import and lib/cmds/tasks_cmds/create-foundation-task.js.
  • Update unit tests and CHANGELOG.md (BREAKING).

Release / semver

Commit uses Conventional Commits feat! with a BREAKING CHANGE: footer so semantic-release on merge to master publishes a major version bump.

Testing

  • yarn test (lint + unit)

Made with Cursor

BREAKING CHANGE: The `lo tasks create-foundation-xml-import` command is removed. The backend endpoint was removed from task-service (FLE-346, https://github.com/lifeomic/task-service/pull/199). Use the GA4GH replacement flow.

Made-with: Cursor
@lifeomic-probot

lifeomic-probot Bot commented Mar 26, 2026

Copy link
Copy Markdown

⚠️ Detected a breaking change in commit 30be11b

Merging this PR will result in a major version bump.

Created by lifeomic-probot (Enforce Semantic Commits)

@cursor

cursor Bot commented Mar 26, 2026

Copy link
Copy Markdown

PR Summary

Low Risk
Low implementation risk (straight deletion), but breaking for any scripts/users relying on lo tasks create-foundation-xml-import and the removed /v1/tasks/system/foundation-xml-import flow.

Overview
Removes the lo tasks create-foundation-xml-import CLI subcommand by deleting lib/cmds/tasks_cmds/create-foundation-task.js and its associated unit tests.

Adds an Unreleased changelog entry marking this as a BREAKING removal and pointing users to the GA4GH replacement flow.

Written by Cursor Bugbot for commit 30be11b. This will update automatically on new commits. Configure here.

@rob-snyder rob-snyder left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM — clean removal of the create-foundation-xml-import task command. Breaking change is properly communicated via conventional commit (feat! + BREAKING CHANGE footer), CHANGELOG entry, and the PR description references the backend removal in task-service#199. No dangling references in code or tests.

@RyanRatcliff
RyanRatcliff merged commit 2526ef4 into master Mar 26, 2026
5 checks passed
@RyanRatcliff
RyanRatcliff deleted the FLE-346-remove-foundation-xml-import branch March 26, 2026 12:57
@github-actions

Copy link
Copy Markdown

🎉 This PR is included in version 14.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants