Repository navigation
CI: Grant issues read to the reusable workflows - #476
Closed
ModeSevenIndustrialSolutions wants to merge 1 commit into
Closed
ModeSevenIndustrialSolutions wants to merge 1 commit into
ModeSevenIndustrialSolutions wants to merge 1 commit into
Conversation
Every pull request is failing to start Python Build/Test, and has
been since the v0.3.1 bump landed on 2026-08-31.
python-workflows v0.3.1 added a permission request to one of its
jobs:
issues: read # Read maintainer-approved CVE bypass issues
A called workflow cannot hold a permission its caller has not
granted, so both callers here fail at startup, before any job
exists.
The failure mode is close to invisible. There is no failing job to
open and no annotation naming the cause; startup_failure produces no
check run at all, so Python Tests, Python Audit, Python Build,
Generate SBOM and Grype Audit SBOM simply vanish from the checks
list rather than turning red. A pull request looks green because the
checks that would have failed are absent.
Confirmed on every commit pushed to feat/flexible-url-handling since
the bump: eleven runs, all startup_failure, all with zero jobs.
Ruled out before concluding, rather than guessing from the name:
the pinned commit resolves, the reusable declares no required
secrets, and the caller passes no inputs at all. Diffing the
job-level permissions between v0.3.0 and v0.3.1 isolates the single
change that matters.
build-test-release.yaml has the same gap, so releases are affected
too; that one runs on tag and has not been exercised yet.
Also drops two comments reading "Pinned to python-workflows v0.1.0
release commit" and "v0.1.1" while sitting beside a v0.3.1 pin.
Neither survived a version bump, so the annotation on the uses: line
is the only record worth keeping.
This pull request cannot exercise the fix. build-test.yaml filters
'!.github/**' and this change touches nothing else, so Python
Build/Test will not appear here at all --- its absence is the path
filter, not the bug. The first pull request afterwards that touches
a non-.github path will show the jobs, or it will not.
Co-authored-by: Claude <noreply@anthropic.com>
Signed-off-by: Matthew Watkins <mwatkins@linuxfoundation.org>
ModeSevenIndustrialSolutions
requested review from
a team
and
a balanced review from Copilot
September 1, 2026 18:09
There was a problem hiding this comment.
🟢 Approval recommended
Pull request overview
Grants reusable Python workflows the required read access to CVE bypass issues, preventing startup failures.
Changes:
- Adds
issues: readto build/test and release jobs. - Removes outdated pin-version comments.
File summaries
| File | Description |
|---|---|
.github/workflows/build-test.yaml |
Grants issue read access to the reusable test workflow. |
.github/workflows/build-test-release.yaml |
Grants issue read access to the reusable release workflow. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 0
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
ModeSevenIndustrialSolutions
marked this pull request as draft
September 1, 2026 18:13
Contributor
Author
|
Don't fix here, the fix needs to land elsewhere. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every pull request is failing to start
Python Build/Testmainis broken, and quietly. Same defect as lfreleng-actions/github2gerrit-action#408, which diagnosed it there.python-workflowsv0.3.1 added a permission request to one of its jobs:A called workflow cannot hold a permission the caller has not granted. Neither caller here grants
issues: read, so the run fails at startup, before any job exists.python-workflows/build-test.yaml@v0.3.1contents: read,pull-requests: read,issues: readcontents: read,pull-requests: readpython-workflows/build-test-release.yaml@v0.3.1contents: read/write,id-token: write,attestations: write,issues: readcontents: write,id-token: write,attestations: writeThe bump landed on 2026-08-31 in #471 and the equivalent for
build-test.yaml.Why nobody noticed
There is no failing job to open and no annotation naming the cause, and
startup_failureproduces no check run at all — soPython Tests (3.10–3.14),Python Audit,Python Build,Generate SBOMandGrype Audit SBOMvanish from the checks list rather than turning red. A PR looks green because the checks that would have failed are absent.Confirmed on every commit pushed to
feat/flexible-url-handlingsince the bump — eleven runs, allstartup_failure, all with zero jobs:What I ruled out first
I initially reached the wrong conclusion here, by reading the copy of
build-test.yamlon a feature branch that predates the bump — it still showedv0.3.0, which does not requestissues: read. For apull_requestevent the workflow comes from the merge ref, so a branch that does not touch.github/runsmain's copy, which isv0.3.1. Worth stating because it is an easy way to mis-diagnose this.Having corrected that, I eliminated the other causes of
startup_failurerather than guessing from the name:Diffing the job-level
permissions:blocks between the two pins isolates the one change that matters:The change
Two lines, one per caller. Nothing else.
Also drops two comments reading
# Pinned to python-workflows v0.1.0 release commitandv0.1.1while sitting beside a pin annotatedv0.3.1. Neither survived a version bump, so the annotation on theuses:line is the only record worth keeping.Verification
zizmor(per AGENTS.md §2.5),actionlintandyamllintall clean:This PR cannot exercise the fix itself.
build-test.yamlfilters'!.github/**', and this change touches nothing else, soPython Build/Testwill not appear on this PR at all — its absence here is the path filter, not the bug. The first PR afterwards that touches a non-.githubpath will show thebuild-testjobs, or it will not. #475 is the obvious candidate.Related
gerrit-clone-actionhas byte-identical callers and is failing the same way; a matching PR follows there.