Skip to content

fix(runtime): preserve retained child Window globals - #1630

Open
ldm0 wants to merge 1 commit into
mainfrom
wpt/20261017-retained-child-window-timers
Open

ldm0 wants to merge 1 commit into
mainfrom
wpt/20261017-retained-child-window-timers

Conversation

@ldm0

@ldm0 ldm0 commented Oct 16, 2026

Copy link
Copy Markdown
Member

Retained child Window timer and EventTarget methods now resolve the receiver's captured native binding instead of acting on a replacement iframe realm. Listener argument conversion cannot redirect a captured Window operation into a replacement document.

Includes the required EventTarget routing in the same PR. Native and CDP regressions cover retained globals, timer registration/cancellation, event registration/dispatch, borrowed methods, reentrant conversion, and iframe removal/reinsertion.

Based directly on main; no prerequisite PRs.

Validation before commit:

  • cargo fmt --all
  • cargo clippy --workspace --all-targets --all-features -- -D warnings
  • cargo nextest run --no-fail-fast: Summary [ 119.282s] 20252 tests run: 20252 passed (9 slow), 18 skipped (32 threads, no retries).

@github-actions

Copy link
Copy Markdown

Sequential Navigation Soak A/B

✅ HEAD completed the 200-navigation resilience and memory observation.

One browser process, one target, and one CDP session navigate CSDN → SegmentFault → Huaban → example.com repeatedly. This run issued 200 Page.navigate commands per binary.

Common ancestor 468533ced2 → HEAD 7732bd7484; benchmark order: head-first; workflow: success.

Session resilience

Metric Base HEAD
Attempted / planned 200 / 200 200 / 200
Direct observable pass 196 / 200 180 / 200
Failures / recovered 4 / 4 20 / 20
Recovery failures 0 0
Lifecycle order violations 0 0
Network order violations 0 0
Wall time 561.4 s 887.2 s

A public-page failure is reported separately from an unrecoverable session. The soak requires all navigation attempts, zero failed recovery, zero lifecycle/network ordering violations, and complete resource evidence.

Process-tree memory

Metric Base HEAD Δ
Boundary samples 200 200 0
Boundary RSS samples 200 200 0
Boundary PSS samples 200 200 0
Periodic peak RSS 245.6 MiB 248.0 MiB +2.4 MiB
Periodic peak PSS 242.3 MiB 244.3 MiB +2.0 MiB
RSS · first 10 avg 176.8 MiB 170.7 MiB -6.1 MiB
RSS · last 10 avg 182.7 MiB 182.6 MiB -0.0 MiB
RSS · last − first window +5.8 MiB +11.9 MiB +6.1 MiB
RSS · warm slope / 100 nav +4.7 MiB +5.2 MiB +0.6 MiB
PSS · first 10 avg 174.0 MiB 167.3 MiB -6.7 MiB
PSS · last 10 avg 179.0 MiB 179.4 MiB +0.4 MiB
PSS · last − first window +5.1 MiB +12.1 MiB +7.1 MiB
PSS · warm slope / 100 nav +4.3 MiB +5.3 MiB +1.0 MiB
Peak file descriptors 63 62 -1
Peak threads 31 29 -2

HEAD memory by 50-navigation quarter

HEAD range Avg RSS Final RSS Peak RSS Avg PSS Final PSS Peak FD
1–50 175.1 MiB 130.6 MiB 213.3 MiB 171.5 MiB 127.0 MiB 54
51–100 176.0 MiB 172.4 MiB 207.8 MiB 172.8 MiB 169.1 MiB 57
101–150 178.5 MiB 168.7 MiB 204.8 MiB 175.1 MiB 165.1 MiB 54
151–200 182.2 MiB 176.9 MiB 213.5 MiB 178.8 MiB 173.7 MiB 54

Raw reports and per-navigation boundary samples: workflow run and full sequential-navigation-soak-results artifact.

Public-site timing and memory are observational. Use the A/B deltas and trend shape as evidence, not as a deterministic performance threshold.

@github-actions

Copy link
Copy Markdown

CI Regression Report

Source CI run · source state at render: in_progress · artifacts: 6/6

Check Status Signal
Release regression ✅ HEAD/base failures 0/0; raw binary +0.003155%
Frontend differential ✅ 1,020/1,020 cases matched; 0 issues
Agent episodes ✅ 8/8 Moli episodes passed; 0 failures
Runtime/CDP contracts ✅ 26 contract cases; 0 failures
CDP smoke ✅ 52/52 groups passed; 621 scenarios
WebMainBench ✅ 545/545 completed; 0 unexpected failures
Release regression — ✅ HEAD/base failures 0/0; raw binary +0.003155%

Package and image size

Metric Base HEAD Delta Delta %
Raw binary 153.09 MiB 153.09 MiB +4.95 KiB +0.003155%
Stripped binary 106.39 MiB 106.39 MiB +4.00 KiB +0.003672%
gzip binary 52.71 MiB 52.72 MiB +1.40 KiB +0.002587%
Rootfs 159.99 MiB 159.99 MiB 0 B 0.00%
gzip rootfs 61.75 MiB 61.75 MiB +516 B +0.000797%

Startup latency and PSS

Case Base p50 HEAD p50 Delta Base PSS HEAD PSS Delta
Serve ready 27.18 ms 27.22 ms +0.04 ms 4.30 MiB 4.21 MiB −96.00 KiB
CDP first page 49.84 ms 50.88 ms +1.03 ms 3.57 MiB 4.56 MiB +1011.50 KiB
CDP warm page 12.19 ms 11.40 ms −0.79 ms 50.59 MiB 50.60 MiB +7.50 KiB
CLI about:blank 15.74 ms 14.97 ms −0.77 ms 1.87 MiB 3.68 MiB +1.81 MiB
CLI local JS 18.79 ms 19.66 ms +0.87 ms 3.19 MiB 2.26 MiB −955.50 KiB

Concurrency matrix

Concurrency Base p50 HEAD p50 Delta Base PSS HEAD PSS Delta HEAD failures Unstable B/H
1 18.10 ms 18.30 ms +0.20 ms 621.00 KiB 616.00 KiB −5.00 KiB 0 0/0
5 21.15 ms 40.89 ms +19.74 ms 26.55 MiB 4.67 MiB −21.88 MiB 0 0/0
10 20.09 ms 36.11 ms +16.02 ms 18.35 MiB 5.78 MiB −12.58 MiB 0 0/0
25 21.45 ms 38.96 ms +17.51 ms 12.59 MiB 5.38 MiB −7.21 MiB 0 0/0
100 22.01 ms 41.87 ms +19.87 ms 16.89 MiB 6.85 MiB −10.04 MiB 0 0/0
Frontend differential — ✅ 1,020/1,020 cases matched; 0 issues
Match DOM mismatch Diagnostic mismatch Moli error Reference error Infrastructure error Mismatched frames Duration
1,020 0 0 0 0 0 0 6m 33.03s
Agent episodes · Moli vs Chromium — ✅ 8/8 Moli episodes passed; 0 failures
Fast contract Episodes Passed Assertions Ready p50 Episode p50
Moli 8 8 47/47 3.32 ms 24.20 ms
Chromium 8 8 47/47 239.90 ms 85.39 ms
Operation p50 Chromium Moli Delta Delta %
navigate 42.13 ms 5.87 ms −36.25 ms −86.06%
observe 0.75 ms 0.92 ms +0.17 ms +23.20%
fill 3.71 ms 3.26 ms −0.45 ms −12.09%
click 3.16 ms 4.02 ms +0.86 ms +27.11%
Idle-resource episode Peak RSS Peak PSS Average CPU Peak CPU Peak processes Sampler
Moli 66.57 MiB 63.54 MiB 0.72% 8.01% 1 ✅
Chromium 1281.67 MiB 405.41 MiB 2.19% 96.15% 13 ⚠️ PSS partial
Runtime and CDP session contracts — ✅ 26 contract cases; 0 failures
Suite Cases Failures Median case p50 Median case p95 Median peak PSS p50
Synthetic fetch 13 0 17.02 ms 17.96 ms 805.00 KiB
Long-lived CDP session 13 0 18.00 ms 18.22 ms —
CDP smoke — ✅ 52/52 groups passed; 621 scenarios

Workers: 4 · cumulative group time: 194.03 s · failed groups: 0

Slowest group Scenarios Duration Status
scrollbar-visibility 22 28.11 s ✅
target-lifecycle 24 16.32 s ✅
dom-input 27 13.20 s ✅
chromium-cdp 56 11.28 s ✅
multi-page 45 11.02 s ✅
WebMainBench · 545 pages — ✅ 545/545 completed; 0 unexpected failures
Completed Successful Expected DNS failure Unexpected failures Panics Crashes Timeouts Empty output
545/545 544 1 0 0 0 0 0

Frozen HTML · Linux · --wait done · 45 seconds per page · no retries. Content quality is evaluated separately.

Diagnostics: webmainbench-results — every page's Markdown, stderr, and exit status. Source run and artifacts

All artifact fields are parsed by the trusted default-branch renderer; missing or invalid inputs remain visible as unavailable.

@github-actions

Copy link
Copy Markdown

Spider Bench A/B

✅ All benchmark browser service runs completed; results are informational.

Public HEAD: 184 / 240 rows; 38 / 48 sites produced rows; 10 unexpected empty sites.

✅ Deterministic fixture contract is clean.

Common ancestor 468533ced256 → HEAD 7732bd74843d; benchmark order: head-first; workflow: success.

Public 48-site run · informational

Metric Base HEAD Δ
Run status success success —
Extracted rows / contract 184 / 240 184 / 240 0 (0.00%)
Contract fill 76.67% 76.67% 0.00 pp (0.00%)
Sites with rows 38 / 48 38 / 48 0 (0.00%)
Sites meeting row contract 36 / 48 36 / 48 0 (0.00%)
Unexpected empty sites 10 10 0 (0.00%)
Partial-row sites 2 2 0 (0.00%)
Site outcomes extracted: 37; HTTP error + rows: 1; empty: 7; HTTP error + empty: 1; snapshot error + empty: 2 extracted: 36; HTTP error + rows: 2; empty: 7; HTTP error + empty: 1; snapshot error + empty: 2 —
Observed duration 101.69 s 55.09 s -46.60 s (-45.82%)
Estimated CPU 52.45 s 47.39 s -5.06 s (-9.65%)
Peak PSS 266.89 MiB 277.71 MiB +10.81 MiB (+4.05%)
Peak RSS 270.53 MiB 281.69 MiB +11.16 MiB (+4.13%)
Peak threads 26 27 +1 (+3.85%)
Mismatched sites 0 0 0
Timeout with items 0 0 0
Category rows Base HEAD Δ
news 35 / 40 35 / 40 0
stocks 20 / 40 20 / 40 0
tech 35 / 40 35 / 40 0
sports 27 / 40 27 / 40 0
games 37 / 40 37 / 40 0
life 30 / 40 30 / 40 0

Public-site content, timing, and memory are noisy. This single A/B run reports evidence only; site outcome counts explain missing rows without treating them as a deterministic regression.

CPU and memory timelines

These are bounded 40-point views of the same complete process-tree samples used by the HTML report. CPU uses 100% per occupied logical core; memory lines are RSS first and PSS second when complete PSS samples are available.

Base

xychart-beta
    title "Base CPU"
    x-axis "Elapsed seconds" [2.538, 3.039, 5.543, 8.547, 11.551, 14.054, 17.058, 20.061, 22.565, 25.567, 28.572, 31.077, 34.081, 37.085, 39.587, 42.591, 45.593, 48.097, 51.103, 54.107, 56.61, 59.613, 62.618, 65.119, 68.124, 71.13, 73.631, 76.635, 79.64, 81.142, 82.143, 85.146, 88.149, 90.652, 93.655, 96.658, 99.161, 101.163]
    y-axis "CPU percent" 0 --> 500
    line [123.74, 147.7, 175.92, 105.72, 127.91, 117.67, 7.99, 0, 4, 4, 5.99, 0, 0, 2, 3.99, 4, 5.99, 0, 8, 0, 4, 2, 2, 0, 0, 5.99, 4, 63.99, 101.94, 99.91, 135.84, 141.96, 121.85, 115.85, 87.91, 119.88, 19.97, 210.05]
Loading
xychart-beta
    title "Base memory: RSS then PSS"
    x-axis "Elapsed seconds" [0.036, 2.538, 3.039, 5.543, 8.547, 11.551, 14.054, 17.058, 20.061, 22.565, 25.567, 28.572, 31.077, 34.081, 37.085, 39.587, 42.591, 45.593, 48.097, 51.103, 54.107, 56.61, 59.613, 62.618, 65.119, 68.124, 71.13, 73.631, 76.635, 79.64, 81.142, 82.143, 85.146, 88.149, 90.652, 93.655, 96.658, 99.161, 101.163, 101.69]
    y-axis "Memory MiB" 0 --> 500
    line [12.09, 125.66, 137.14, 161.6, 163.95, 170.72, 166.2, 176.33, 145.85, 144.83, 144.83, 145.23, 145.23, 145.23, 145.61, 146.55, 147.1, 147.1, 147.07, 142.05, 140.07, 140.17, 140.24, 140.32, 140.39, 140.36, 137.36, 136.67, 138.56, 152.95, 270.53, 198.43, 189.12, 168.23, 168.64, 154.09, 158.8, 148.72, 192.34, 0]
    line [8.98, 122.1, 133.58, 158.04, 160.4, 167.15, 162.64, 172.9, 142.24, 141.22, 141.22, 141.63, 141.63, 141.63, 142, 142.94, 143.49, 143.49, 143.46, 138.43, 136.45, 136.55, 136.62, 136.7, 136.77, 136.75, 133.75, 133.08, 134.86, 149.34, 266.89, 194.74, 186.53, 165.1, 164.97, 150.42, 155.13, 144.95, 188.75, 0]
Loading

HEAD

xychart-beta
    title "HEAD CPU"
    x-axis "Elapsed seconds" [1.54, 2.04, 3.041, 4.544, 6.047, 7.548, 9.049, 10.552, 12.054, 14.056, 15.559, 17.059, 18.562, 20.064, 21.565, 23.066, 24.566, 26.067, 27.569, 29.07, 30.572, 32.074, 33.576, 34.577, 35.078, 36.581, 38.084, 39.586, 41.589, 43.092, 44.594, 46.097, 47.597, 49.099, 50.602, 52.104, 53.606, 54.608]
    y-axis "CPU percent" 0 --> 500
    line [1.99, 0, 0, 2, 0, 2, 0, 115.83, 121.8, 171.78, 165.81, 53.9, 185.75, 93.82, 29.96, 155.9, 96.07, 72.02, 37.95, 41.95, 113.8, 127.7, 131.84, 113.95, 129.79, 153.63, 143.68, 147.82, 135.69, 95.8, 9.99, 147.72, 59.92, 4, 113.79, 175.56, 137.76, 197.66]
Loading
xychart-beta
    title "HEAD memory: RSS then PSS"
    x-axis "Elapsed seconds" [0.038, 1.54, 2.04, 3.041, 4.544, 6.047, 7.548, 9.049, 10.552, 12.054, 14.056, 15.559, 17.059, 18.562, 20.064, 21.565, 23.066, 24.566, 26.067, 27.569, 29.07, 30.572, 32.074, 33.576, 34.577, 35.078, 36.581, 38.084, 39.586, 41.589, 43.092, 44.594, 46.097, 47.597, 49.099, 50.602, 52.104, 53.606, 54.608, 55.091]
    y-axis "Memory MiB" 0 --> 500
    line [12.31, 64.45, 64.45, 63.44, 63.44, 63.44, 63.44, 63.44, 118.36, 127.34, 163.26, 185.68, 155.59, 186.27, 151.38, 185.73, 172.42, 154.09, 163.93, 149.54, 153.83, 185.16, 162.04, 190.1, 281.69, 203.11, 214.46, 188.93, 162.6, 178.73, 159.79, 153.74, 207.21, 183.14, 164.11, 189.99, 190.75, 192.48, 199.38, 0]
    line [9.16, 60.98, 60.98, 59.97, 59.97, 59.97, 59.97, 59.97, 114.96, 123.95, 160.06, 182.31, 152.14, 182.78, 147.84, 182.11, 168.81, 150.44, 160.64, 145.54, 150.19, 181.45, 158.48, 186.5, 277.71, 199.46, 210.85, 185.27, 158.99, 175.36, 156.14, 150.09, 204.35, 179.5, 160.46, 186.45, 186.62, 189.38, 196.05, 0]
Loading

Deterministic fixture · required contract

The fixture exercises 15 routes: 8 are expected to emit rows and 7 intentionally exercise empty, loading, or timeout behavior.

Metric Base HEAD Δ
Run status success success —
Extracted rows / contract 40 / 40 40 / 40 0 (0.00%)
Contract fill 100.00% 100.00% 0.00 pp (0.00%)
Sites with rows 8 / 15 8 / 15 0 (0.00%)
Sites meeting row contract 15 / 15 15 / 15 0 (0.00%)
Unexpected empty sites 0 0 0
Partial-row sites 0 0 0
Site outcomes extracted: 7; HTTP error + rows: 1; empty: 3; timeout + empty: 4 extracted: 7; HTTP error + rows: 1; empty: 3; timeout + empty: 4 —
Observed duration 19.86 s 19.87 s +0.01 s (+0.07%)
Estimated CPU 0.41 s 0.46 s +0.05 s (+11.89%)
Peak PSS 66.95 MiB 67.15 MiB +0.20 MiB (+0.30%)
Peak RSS 70.44 MiB 70.45 MiB +0.01 MiB (+0.01%)
Peak threads 18 18 0 (0.00%)
Mismatched sites 0 0 0
Timeout with items 0 0 0

Full HTML, JSON, CSV, logs, and page snapshots: workflow run and full spider-bench-results artifact.

The public-web A/B is informational. The exact HEAD fixture contract runs as a separate required CI check; timing and public-site content deltas remain non-blocking.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant