Skip to content

chore(deps): bump docker/login-action from 4 to 4.5.1 #6064

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rtibbles merged 1 commit into from
Aug 2, 2026
+1 −1
Merged

chore(deps): bump docker/login-action from 4 to 4.5.1 #6064

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/containerbuild.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ jobs:

- name: Log in to Docker Hub
if: github.event_name != 'pull_request'
uses: docker/login-action@v4
uses: docker/login-action@v4.5.1

@rtibblesbot rtibblesbot Aug 1, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion: This narrows a floating major into an exact pin, which has two effects beyond the version change.

First, it's a downgrade: @v4 resolves to v4.6.0 today, so this moves CI back two releases. Second, future 4.x patches — including security patches — stop arriving automatically and need a fresh Dependabot PR each time. Neither is signalled by the title "bump ... from 4 to 4.5.1".

It's also the only exact pin among the Docker actions here: docker/setup-qemu-action@v4 (42, 98), docker/setup-buildx-action@v4 (45, 101), docker/metadata-action@v6 (57), docker/build-push-action@v7 (64, 104) all float.

Suggest closing this and keeping @v4. If exact/SHA pinning is wanted for supply-chain reasons, that's worth doing deliberately across all actions rather than landing on one step.

Worth noting the green CI isn't evidence here — this step is guarded by if: github.event_name != 'pull_request', so it was skipped on the PR build. v4.5.1 would first execute on the post-merge push to unstable.

with:
registry: ghcr.io
username: ${{ github.actor }}
Expand Down
Loading