Repository navigation
docs(evals): correct the temperature guidance in the config schema - #207
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the author-facing JSON Schema guidance for generation.temperature to correct inaccurate vendor-specific claims and encourage recording the explicitly validated temperature per evaluator step.
Changes:
- Rewrites the
generation.temperatureschemadescriptionto remove incorrect model-specific assertions (Gemini 3 “remove parameter”, GPT-5 “400 unless 1”). - Clarifies that
nullmeans “omit the parameter”, and should be used only when a model rejects non-default temperatures and omission is the documented approach. - Reinforces that
temperatureis required so each step records a deliberate choice.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Salvaged from #187, which was closed because its Gemini-3-must-be-1 check contradicts a decision we've since made deliberately. The schema wording is independent of that check and still wrong on
main.1. "Google recommends removing the parameter" (Gemini 3) — false. Google's docs say the opposite: "For all Gemini 3 models, we strongly recommend keeping the temperature parameter at its default value of
1.0." Keeping it at a value is not removing it.2. "GPT-5 (rejects any value but 1 with a 400)" — false. I verified
gpt-5.4-2026-03-05against the live API: it accepts a temperature and honours it.The description also instructed authors to use
nullfor Gemini 3, which is now backwards — the ela-reading evaluators pin an explicit0, tested and preferred, except Organizational Structure at1.What replaces it
The per-model list is gone on purpose. It was a set of claims that rot — two had already rotted — and it invited
nullwherever a vendor merely recommended a default. The one hard constraint left is the only one that is a real API rejection rather than advice, and I verified it: Opus 5 returns 400 on a non-default temperature.I did not reuse #187's phrasing verbatim. It argued for explicit numbers partly because our TypeScript provider coerced
nullto0viarequest.temperature ?? 0— #199 fixed that, so the argument no longer holds and repeating it would be stating a bug we don't have.One line changed. All 6 repo checks pass.