Skip to content

LBRON-1363 UC2 answer and sources review #155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tdn wants to merge 5 commits into
base: development
Choose a base branch
from
Open

LBRON-1363 UC2 answer and sources review #155

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
8fe541c
Make all annotations annotation targets as well.
tdn Jun 30, 2026
f1d6409
Add annotation target types as env variable to annotation-review
tdn Jul 9, 2026
1d741c7
Add AnnotationTarget to ODRL config
tdn Jul 14, 2026
4cc854a
Fix read access to question-answering for human validation
tdn Jul 16, 2026
18612b2
Merge branch 'development' of github.com:lblod/app-decide into featur…
tdn Jul 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions compose/validation.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ services:
logging: *default-logging
environment:
DEFAULT_MU_AUTH_SCOPE: 'http://services.semantic.works/annotation-review-service'
ANNOTATION_TARGET_TYPES: 'http://www.w3.org/ns/oa#Annotation,http://mu.semte.ch/vocabularies/ext/AnnotationTarget'
TZ: Europe/Brussels
volumes:
- ../config/annotation-review:/config
Expand Down
12 changes: 12 additions & 0 deletions config/authorization/config.ttl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,7 @@ ext:decideAuthorizationPolicy a odrl:Set ;
ext:allowReadForAiSlice ,
ext:allowReadOsloOrgsForHumanValidation ,
ext:allowReadForHumanValidation ,
ext:allowQuestionAnsweringReadForHumanValidation,
ext:allowWriteForHumanValidation ,
ext:allowReadForQuestionAnswering ,
ext:allowWriteForQuestionAnswering ,
Expand Down Expand Up @@ -282,6 +283,13 @@ ext:allowReadForHumanValidation a odrl:Permission ;
odrl:assignee ext:publicParty ;
ext:scope "http://services.semantic.works/annotation-review-service" .

ext:allowQuestionAnsweringReadForHumanValidation a odrl:Permission ;
odrl:action odrl:read ;
odrl:target ext:decideQuestionAnsweringSlice ;
odrl:assigner ext:decideSystem ;
odrl:assignee ext:publicParty ;
ext:scope "http://services.semantic.works/annotation-review-service" .

ext:allowWriteForHumanValidation a odrl:Permission ;
odrl:action odrl:modify ;
odrl:target ext:decideHumanValidationSlice ;
Expand Down Expand Up @@ -620,6 +628,10 @@ ext:ExtReviewAnnotationAsset a odrl:Asset, sh:NodeShape ;
odrl:partOf ext:decideHumanValidationSlice ;
sh:targetClass ext:ReviewAnnotation .

ext:ExtAnnotationTargetAsset a odrl:Asset, sh:NodeShape ;
odrl:partOf ext:decideHumanValidationSlice ;
sh:targetClass ext:AnnotationTarget .

ext:ExtCorrectionAnnotationAsset a odrl:Asset, sh:NodeShape ;
odrl:partOf ext:decideHumanValidationSlice ;
sh:targetClass ext:CorrectionAnnotation .
Expand Down
18 changes: 9 additions & 9 deletions config/resources/annotation.lisp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,14 @@
(in-package :mu-cl-resources)

(define-resource annotation ()
(define-resource annotation-target () ;; generic resource class to serve as a target for annotations, to be extended with specific classes
:class (s-prefix "ext:AnnotationTarget")
:has-many `((annotation :via ,(s-prefix "oa:hasTarget")
:as "annotations"
:inverse t))
:resource-base (s-url "http://data.lblod.info/id/annotation-targets/")
:on-path "annotation-targets")

(define-resource annotation (annotation-target)
:class (s-prefix "oa:Annotation")
:properties `((:confidence :number ,(s-prefix "nif:confidence"))
(:motivated-by :url ,(s-prefix "oa:motivatedBy")))
Expand All @@ -12,14 +20,6 @@
:resource-base (s-url "http://data.lblod.info/id/annotations/")
:on-path "annotations")

(define-resource annotation-target () ;; generic resource class to serve as a target for annotations, to be extended with specific classes
:class (s-prefix "ext:AnnotationTarget")
:has-many `((annotation :via ,(s-prefix "oa:hasTarget")
:as "annotations"
:inverse t))
:resource-base (s-url "http://data.lblod.info/id/annotation-targets/")
:on-path "annotation-targets")

(define-resource annotation-body () ;; generic resource class to serve as a body for annotations, to be extended with specific classes
:class (s-prefix "ext:AnnotationBody")
:has-one `((annotation :via ,(s-prefix "oa:hasBody")
Expand Down