Repository navigation
Conversation
main-ci only triggers on the main branch, so pull requests targeting lts/* branches had no test coverage. Generated with [Devin](https://devin.ai) Co-Authored-By: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Gate each suite on changed paths and reuse the existing reusable test workflows. Generated with [Devin](https://devin.ai) Co-Authored-By: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com>
|
I noticed a potential compatibility issue with the type-checking step in the new LTS CI workflow. the workflow currently invokes I'd suggest verifying the target names across |
You are correct, but |
1 similar comment
You are correct, but |
part of #45070
Summary
main-ci.ymlonly triggers onmain, so PRs targetinglts/*currently only run the cherry-pick provenance check — no tests or type checks..github/workflows/lts-ci.ymlfor PRs tolts/**. Acheck-changesjob (dorny/paths-filter) gates each suite on changed paths:API Unit Tests(api/**,Makefile,dev/pyrefly-check-local): same unit commands as this branch'sapi-tests.yml; integration tests and coverage upload are not included.API Type Check(same paths):make type-check-core(pyrefly + mypy), same as theRun Type Checksstep instyle.yml.Web Tests(web/**,packages/**, pnpm files): calls the existing reusableweb-tests.yml.Dify Agent Tests(dify-agent/**): calls the existing reusabledify-agent-tests.yml.main, so the provenance check is expected to fail and needs an admin override.Known baseline failure (not caused by this PR)
API Unit Testscurrently fails onlts/1.17.x:api/uv.lockpinsaiohttp 3.14.4, which importsyarl.query_to_pairs, but the lock pinsyarl 1.23.0, which doesn't have it. Anything importingfastopenapi → aiohttpfails (swagger spec tests,test_app_factory, controller test collection). Keeping this PR open until that is fixed on the branch.Test plan
actionlintclean (only the knowndepot-ubuntu-24.04custom runner label warning)make type-check-corepasses locally on a cleanlts/1.17.xcheckout (pyrefly ×3 configs + mypy: no issues in 1796 files)LTS CI / API Unit Testsgreen after the aiohttp/yarl lock fix landsLTS CIjobs green on this PRGenerated with Devin