Skip to content

Remove dead code, unused dependencies, and stale docs#256

Merged
kylebrowning merged 1 commit into
mainfrom
chore/dead-code-cleanup
Jul 14, 2026
Merged

Remove dead code, unused dependencies, and stale docs#256
kylebrowning merged 1 commit into
mainfrom
chore/dead-code-cleanup

Conversation

@kylebrowning

Copy link
Copy Markdown
Owner

Replaces #250 (closed during a base-branch cleanup).

  • Base64.swift: 1128 → 512 lines — removes the vendored decode half and dead String helpers (production only uses encodeBytes); tests now use a small Foundation-based base64url helper.
  • Deletes unused LoggingKeys; deprecates P256.Signing.PrivateKey.loadFrom(string:) (misnamed, adds nothing over init(pemRepresentation:)).
  • Drops unused imports and APNSTestServer's unused Logging/Crypto/NIOSSL/NIOHTTP2 target deps; removes the swift-nio-http2 package dependency entirely (no target uses it).
  • DocC: removes the Logging section documenting an API that no longer exists; fixes stale paths and copy-pasted doc comments; fixes EmptyPayload's wrong license header.
  • Concurrency: APNSClientProtocol: Sendable, conditional APNSRequest: Sendable.

@kylebrowning kylebrowning force-pushed the chore/dead-code-cleanup branch from 9423f68 to fd20a2f Compare July 14, 2026 06:07
@kylebrowning kylebrowning merged commit b22d30a into main Jul 14, 2026
6 checks passed
@kylebrowning kylebrowning deleted the chore/dead-code-cleanup branch July 14, 2026 06:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant