Skip to content

Expand test coverage and remove low-value tests#255

Merged
kylebrowning merged 1 commit into
mainfrom
test/coverage-expansion
Jul 14, 2026
Merged

Expand test coverage and remove low-value tests#255
kylebrowning merged 1 commit into
mainfrom
test/coverage-expansion

Conversation

@kylebrowning

Copy link
Copy Markdown
Owner

Replaces #249 (closed during a base-branch cleanup).

  • First-ever wire tests for liveactivity (update + start), pushtotalk, widgets, and location through a real client; priority-5 and no-expiration header checks.
  • Alert encode variants: localized title/body keys, .fileName sound, all interruption levels.
  • Direct unit tests for APNSRequest.headers (the URLSession client's entire header contract) and APNSEnvironment/APNSBroadcastEnvironment URL composition.
  • withBadge/withSound tests now actually decode and assert the payload; testRequestID asserts the echoed apns-request-id.
  • Removes tests that couldn't fail meaningfully (channel-list encode, two token-window tests subsumed by the boundary test); fixes a test-name typo and tearDown hygiene.

@kylebrowning
kylebrowning force-pushed the test/coverage-expansion branch from 6f0dec8 to f062f89 Compare July 14, 2026 06:01
@kylebrowning
kylebrowning merged commit f435131 into main Jul 14, 2026
6 checks passed
@kylebrowning
kylebrowning deleted the test/coverage-expansion branch July 14, 2026 06:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant