Validate requests in APNSTestServer and fix JWT claim encoding#246
Merged
Conversation
This was referenced Jul 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The mock server was too lax to catch regressions — deleting the client's bearer-token code passed all 88 tests.
Server (matching documented APNs behavior):
authorizationbearer JWTs (structure, ES256 header,iss, numericiat≤ 1h) → 403MissingProviderToken/InvalidProviderToken/ExpiredProviderToken.apns-unique-idon device-push responses;apns-request-idechoed on broadcast paths only.apns-id→ 400BadMessageId; real reason strings (BadPath,MissingChannelId).background+priority-10 rejected, priority 1 and thecontrolspush type accepted.NIOLockedValueBox), a broadcast request log, and a response-override hook for error-path tests.Library fixes the new validation pinned:
iatwas encoded as a JSON string (RFC 7519 requires a number) andkidwas wrongly duplicated into the payload.testToken.