Skip to content

fix: correctly parse PUSHER_USE_SSL environment variable (#6582) - #6680

Merged
talboren merged 1 commit into
keephq:mainfrom
ChickenisLegit:fix/pusher-use-ssl-parsing
Aug 8, 2026
Merged

fix: correctly parse PUSHER_USE_SSL environment variable (#6582)#6680
talboren merged 1 commit into
keephq:mainfrom
ChickenisLegit:fix/pusher-use-ssl-parsing

Conversation

@ChickenisLegit

Copy link
Copy Markdown
Contributor

Closes #6582.

This PR fixes a bug where setting PUSHER_USE_SSL=false in Docker Compose or other environments would evaluate to True.
This occurred because os.environ.get returns a string (e.g. "false"), which evaluated to True since any non-empty string in Python evaluates to True when checked against False (e.g. ssl=False if os.environ.get("PUSHER_USE_SSL", False) is False else True).

Changes

  • Updated PUSHER_USE_SSL parsing to properly handle string booleans ("false", "0", "true", "1", "yes", "on").
  • Defaults to "false" if the environment variable is not present, matching the existing fallback logic.

@dosubot dosubot Bot added size:XS This PR changes 0-9 lines, ignoring generated files. Bug Something isn't working labels Aug 8, 2026
@CLAassistant

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@dosubot dosubot Bot added the lgtm This PR has been approved by a maintainer label Aug 8, 2026
@talboren
talboren enabled auto-merge (squash) August 8, 2026 08:15
@ChickenisLegit

Copy link
Copy Markdown
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@talboren
talboren disabled auto-merge August 8, 2026 08:50
@talboren
talboren merged commit af93f55 into keephq:main Aug 8, 2026
12 of 13 checks passed
@github-actions

github-actions Bot commented Aug 8, 2026

Copy link
Copy Markdown
Contributor

🌈 Fantastic work @ChickenisLegit! Your very first PR to keep has been merged! 🎉🥳

You've just taken your first step into open-source, and we couldn't be happier to have you onboard. 🙌
If you're feeling adventurous, why not dive into another issue and keep contributing? The community would love to see more from you! 🚀

For any support, feel free to reach out on the community: https://slack.keephq.dev. Happy coding! 👩‍💻👨‍💻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bug Something isn't working lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[🐛 Bug]: PUSHER_USE_SSL is incorrectly parsed

3 participants