feat(k8s): add previous flag to k8s_get_pod_logs - #79
Open
frodriguez-wasabi wants to merge 1 commit into
Open
Conversation
Pass kubectl logs --previous so agents can read the last terminated container after a restart.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
previousboolean tok8s_get_pod_logsand passkubectl logs --previouswhen it is true.kubectl logs --previous). The current schema only supportedpod_name,namespace,container, andtail_lines, so extra args were dropped.Test plan
go test ./pkg/k8s -run TestHandleKubectlLogsEnhanced(includes previous-container argv assertion)k8s_get_pod_logswithprevious: truereturns terminated-container logs when kubelet still has them