Skip to content

Fix the RSA-PSS guard skipping the whole jwt_spec file #759

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
anakinj merged 1 commit into from
Sep 5, 2026
+8 −10
Merged

Fix the RSA-PSS guard skipping the whole jwt_spec file #759

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 8 additions & 10 deletions spec/jwt/jwt_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@
:secret => 'My$ecretK3y',
:rsa_private => test_pkey('rsa-2048-private.pem'),
:rsa_public => test_pkey('rsa-2048-public.pem'),
:wrong_rsa_private => test_pkey('rsa-2048-wrong-public.pem'),
:wrong_rsa_public => test_pkey('rsa-2048-wrong-public.pem'),
'ES256_private' => test_pkey('ec256-private.pem'),
'ES256_public' => test_pkey('ec256-public.pem'),
Expand Down Expand Up @@ -160,10 +159,6 @@
end

%w[ES256 ES384 ES512 ES256K].each do |alg|
before do
skip 'OpenSSL gem missing RSA-PSS support' unless OpenSSL::PKey::RSA.method_defined?(:sign_pss)
end

context "alg: #{alg}" do
before(:each) do
data[alg] = JWT.encode(payload, data["#{alg}_private"], alg)
Expand All @@ -172,10 +167,11 @@
let(:wrong_key) { OpenSSL::PKey::EC.generate(data["#{alg}_private"].group.curve_name) }

it 'should generate a valid token' do
jwt_payload, header = JWT.decode data[alg], data["#{alg}_public"], true, algorithm: alg
header, body, signature = data[alg].split('.')

expect(header['alg']).to eq alg
expect(jwt_payload).to eq payload
expect(header).to eql(Base64.urlsafe_encode64({ alg: alg }.to_json, padding: false))
expect(body).to eql(Base64.urlsafe_encode64(payload.to_json, padding: false))
expect(signature).not_to be_empty
end

it 'should decode a valid token' do
Expand All @@ -202,6 +198,8 @@
%w[PS256 PS384 PS512].each do |alg|
context "alg: #{alg}" do
before(:each) do
skip 'OpenSSL gem missing RSA-PSS support' unless OpenSSL::PKey::RSA.method_defined?(:sign_pss)

data[alg] = JWT.encode payload, data[:rsa_private], alg
end

Expand All @@ -212,8 +210,8 @@

header, body, signature = token.split('.')

expect(header).to eql(Base64.strict_encode64({ alg: alg }.to_json))
expect(body).to eql(Base64.strict_encode64(payload.to_json))
expect(header).to eql(Base64.urlsafe_encode64({ alg: alg }.to_json, padding: false))
expect(body).to eql(Base64.urlsafe_encode64(payload.to_json, padding: false))

# Validate signature is made of up header and body of JWT
translated_alg = alg.gsub('PS', 'sha')
Expand Down
Loading