Arrays in filters are not parsed correctly

[tlconnor]

According to the documentation:

Arrays are supported automatically, defaulting to an OR clause:

Person.where({ name: ["Joe", "Bill"] }).all()

GET /people?&filter[name][]=Joe&filter[name][]=Bill

This does not appear to be the case - the implementation of parameterize() will concatenate array values rather than splitting them. This means that instead of the documented behavior above, you get:

Person.where({ name: ["Joe", "Bill"] }).all()

GET /people?&filter[name]=Joe,Bill

Here is an example test that illustrates the problem:

it("casts arrays correctly", () => {
  scope = scope.where({ name: ["Joe", "Bill"] })
  expect((<string>scope.toQueryParams())).to.eq("filter[name][]=Joe&filter[name][]=Bill")
})

The result of this test is:

AssertionError: expected 'filter[name]=Joe,Bill' to equal 'filter[name][]=Joe&filter[name][]=Bill'

• expected - actual

-filter[name]=Joe,Bill
+filter[name][]=Joe&filter[name][]=Bill

[tlconnor]

I see there is also a test that asserts the comma method. It would be nice to be able to support the "OR" clause so that Rails can parse the parameter as an array rather than a string.

      it('converts to comma-delimited string', async () => {
        const { data } = await Person.where({ id: [1, 2, 3] }).all()
        expect(data.length).to.eq(1)
      })