[4.x] resolve PHPUnit Notices

Tests/DatabaseAwareTraitTest.php

@@ -10,27 +10,25 @@
 use Joomla\Database\DatabaseAwareTrait;
 use Joomla\Database\DatabaseInterface;
 use Joomla\Database\Exception\DatabaseNotFoundException;
+use PHPUnit\Framework\Attributes\CoversTrait;
+use PHPUnit\Framework\Attributes\TestDox;
 use PHPUnit\Framework\TestCase;
 
 /**
  * Tests for DatabaseAwareTrait class.
  */
+#[CoversTrait(DatabaseAwareTrait::class)]
 class DatabaseAwareTraitTest extends TestCase
 {
     /**
      * @var DatabaseAwareTrait
      */
     protected $object;
 
-    /**
-     * @testdox  Database can be set with setDatabase()
-     *
-     * @covers   \Joomla\Database\DatabaseAwareTrait
-     * @uses     \Joomla\Database\Database
-     */
+    #[TestDox('Database can be set with setDatabase()')]
     public function testGetSetDatabase(): void
     {
-        $db = $this->createMock(DatabaseInterface::class);
+        $db = $this->createStub(DatabaseInterface::class);
 
         $trait = new class () {
             use DatabaseAwareTrait;
@@ -46,11 +44,7 @@ public function getDb()
         $this->assertSame($db, $trait->getDb());
     }
 
-    /**
-     * @testdox  getDatabase() throws an DatabaseNotFoundException, if no database is set
-     *
-     * @covers   \Joomla\Database\DatabaseAwareTrait
-     */
+    #[TestDox('getDatabase() throws an DatabaseNotFoundException, if no database is set')]
     public function testGetDatabaseException(): void
     {
         $this->expectException(DatabaseNotFoundException::class);

Tests/DatabaseExporterTest.php

@@ -7,14 +7,11 @@
 
 namespace Joomla\Database\Tests;
 
-use Joomla\Database\DatabaseExporter;
-use Joomla\Database\DatabaseImporter;
 use Joomla\Database\DatabaseInterface;
 use Joomla\Database\Tests\Stubs\TestDatabaseExporter;
-use Joomla\Database\Tests\Stubs\TestDatabaseImporter;
 use Joomla\Test\TestHelper;
 use PHPUnit\Framework\Attributes\DataProvider;
-use PHPUnit\Framework\MockObject\MockObject;
+use PHPUnit\Framework\Attributes\TestDox;
 use PHPUnit\Framework\TestCase;
 
 /**
@@ -43,9 +40,7 @@ protected function setUp(): void
         $this->exporter = new TestDatabaseExporter();
     }
 
-    /**
-     * @testdox  The exporter is correctly configured when instantiated
-     */
+    #[TestDox('The exporter is correctly configured when instantiated')]
     public function testInstantiation()
     {
         $expected = (object) [
@@ -57,9 +52,7 @@ public function testInstantiation()
         $this->assertSame('xml', TestHelper::getValue($this->exporter, 'asFormat'));
     }
 
-    /**
-     * @testdox  The exporter can be set to XML format
-     */
+    #[TestDox('The exporter can be set to XML format')]
     public function testAsXml()
     {
         $this->assertSame($this->exporter, $this->exporter->asXml(), 'The exporter supports method chaining');
@@ -93,12 +86,11 @@ public static function dataFrom(): array
     }
 
     /**
-     * @testdox  The tables to be exported can be configured
-     *
      * @param   string[]|string  $from                  The name of a single table, or an array of the table names to export.
      * @param   boolean          $shouldRaiseException  Flag indicating the exporter should raise an exception for an unsupported data type
      */
     #[DataProvider('dataFrom')]
+    #[TestDox('The tables to be exported can be configured')]
     public function testFrom($from, bool $shouldRaiseException)
     {
         if ($shouldRaiseException) {
@@ -110,20 +102,15 @@ public function testFrom($from, bool $shouldRaiseException)
         $this->assertSame((array) $from, TestHelper::getValue($this->exporter, 'from'));
     }
 
-    /**
-     * @testdox  A database drier can be set to the exporter
-     */
+    #[TestDox('A database driver can be set to the exporter')]
     public function testSetDbo()
     {
-        /** @var DatabaseInterface|MockObject $db */
-        $db = $this->createMock(DatabaseInterface::class);
+        $db = $this->createStub(DatabaseInterface::class);
 
         $this->assertSame($this->exporter, $this->exporter->setDbo($db), 'The exporter supports method chaining');
     }
 
-    /**
-     * @testdox  The exporter can be configured to export with structure
-     */
+    #[TestDox('The exporter can be configured to export with structure')]
     public function testWithStructure()
     {
         $this->assertSame($this->exporter, $this->exporter->withStructure(false), 'The exporter supports method chaining');
@@ -133,9 +120,7 @@ public function testWithStructure()
         $this->assertFalse($options->withStructure);
     }
 
-    /**
-     * @testdox  The exporter can be configured to export with data
-     */
+    #[TestDox('The exporter can be configured to export with data')]
     public function testWithData()
     {
         $this->assertSame($this->exporter, $this->exporter->withData(true), 'The exporter supports method chaining');

Tests/DatabaseFactoryTest.php

@@ -19,6 +19,7 @@
 use Joomla\Database\StatementInterface;
 use Joomla\Test\TestHelper;
 use PHPUnit\Framework\Attributes\DataProvider;
+use PHPUnit\Framework\Attributes\TestDox;
 use PHPUnit\Framework\TestCase;
 
 /**
@@ -68,12 +69,11 @@ public static function dataGetDriver(): array
     }
 
     /**
-     * @testdox  The factory builds a database driver correctly
-     *
      * @param   string   $adapter               The type of adapter to create
      * @param   boolean  $shouldRaiseException  Flag indicating the factory should raise an exception for an unsupported adapter
      */
     #[DataProvider('dataGetDriver')]
+    #[TestDox('The factory builds a database driver correctly')]
     public function testGetDriver(string $adapter, bool $shouldRaiseException)
     {
         if ($shouldRaiseException) {
@@ -115,13 +115,12 @@ public static function dataGetExporter(): array
     }
 
     /**
-     * @testdox  The factory builds a database exporter correctly
-     *
      * @param   string               $adapter               The type of adapter to create
      * @param   boolean              $shouldRaiseException  Flag indicating the factory should raise an exception for an unsupported adapter
      * @param   DatabaseDriver|null  $databaseDriver        The optional database driver to be injected into the exporter
      */
     #[DataProvider('dataGetExporter')]
+    #[TestDox('The factory builds a database exporter correctly')]
     public function testGetExporter(string $adapter, bool $shouldRaiseException, bool $createDb)
     {
         if ($shouldRaiseException) {
@@ -131,7 +130,7 @@ public function testGetExporter(string $adapter, bool $shouldRaiseException, boo
         $databaseDriver = null;
 
         if ($createDb) {
-            $databaseDriver = $this->createMock(MysqliDriver::class);
+            $databaseDriver = $this->createStub(MysqliDriver::class);
         }
 
         $exporter = $this->factory->getExporter($adapter, $databaseDriver);
@@ -178,13 +177,12 @@ public static function dataGetImporter(): array
     }
 
     /**
-     * @testdox  The factory builds a database importer correctly
-     *
      * @param   string   $adapter               The type of adapter to create
      * @param   boolean  $shouldRaiseException  Flag indicating the factory should raise an exception for an unsupported adapter
      * @param   boolean  $createDb              The optional database driver to be injected into the importer
      */
     #[DataProvider('dataGetImporter')]
+    #[TestDox('The factory builds a database importer correctly')]
     public function testGetImporter(string $adapter, bool $shouldRaiseException, bool $createDb)
     {
         if ($shouldRaiseException) {
@@ -194,7 +192,7 @@ public function testGetImporter(string $adapter, bool $shouldRaiseException, boo
         $databaseDriver = null;
 
         if ($createDb) {
-            $databaseDriver = $this->createMock(MysqliDriver::class);
+            $databaseDriver = $this->createStub(MysqliDriver::class);
         }
 
         $importer = $this->factory->getImporter($adapter, $databaseDriver);
@@ -228,18 +226,17 @@ public static function dataGetIterator(): array
     }
 
     /**
-     * @testdox  The factory builds a database iterator correctly
-     *
      * @param   string  $adapter    The type of adapter to create
      * @param   bool    $createStatement  Statement holding the result set to be iterated.
      */
     #[DataProvider('dataGetIterator')]
+    #[TestDox('The factory builds a database iterator correctly')]
     public function testGetIterator(string $adapter, bool $createStatement)
     {
         $statement = null;
 
         if ($createStatement) {
-            $statement = $this->createMock(StatementInterface::class);
+            $statement = $this->createStub(StatementInterface::class);
         }
 
         $this->assertInstanceOf(
@@ -271,13 +268,12 @@ public static function dataGetQuery(): array
     }
 
     /**
-     * @testdox  The factory builds a database query object correctly
-     *
      * @param   string   $adapter               The type of adapter to create
      * @param   boolean  $shouldRaiseException  Flag indicating the factory should raise an exception for an unsupported adapter
      * @param   boolean  $createDb              The optional database driver to be injected into the importer
      */
     #[DataProvider('dataGetQuery')]
+    #[TestDox('The factory builds a database query object correctly')]
     public function testGetQuery(string $adapter, bool $shouldRaiseException, bool $createDb)
     {
         if ($shouldRaiseException) {
@@ -287,7 +283,7 @@ public function testGetQuery(string $adapter, bool $shouldRaiseException, bool $
         $databaseDriver = null;
 
         if ($createDb) {
-            $databaseDriver = $this->createMock(MysqliDriver::class);
+            $databaseDriver = $this->createStub(MysqliDriver::class);
         }
 
         $this->assertInstanceOf(

Tests/DatabaseImporterTest.php

@@ -7,12 +7,10 @@
 
 namespace Joomla\Database\Tests;
 
-use Joomla\Database\DatabaseImporter;
 use Joomla\Database\DatabaseInterface;
 use Joomla\Database\Tests\Stubs\TestDatabaseImporter;
-use Joomla\Database\Tests\Stubs\TestDatabaseQuery;
 use Joomla\Test\TestHelper;
-use PHPUnit\Framework\MockObject\MockObject;
+use PHPUnit\Framework\Attributes\TestDox;
 use PHPUnit\Framework\TestCase;
 
 /**
@@ -41,9 +39,7 @@ protected function setUp(): void
         $this->importer = new TestDatabaseImporter();
     }
 
-    /**
-     * @testdox  The importer is correctly configured when instantiated
-     */
+    #[TestDox('The importer is correctly configured when instantiated')]
     public function testInstantiation()
     {
         $expected = (object) [
@@ -54,30 +50,23 @@ public function testInstantiation()
         $this->assertSame('xml', TestHelper::getValue($this->importer, 'asFormat'));
     }
 
-    /**
-     * @testdox  The importer can be set to XML format
-     */
+    #[TestDox('The importer can be set to XML format')]
     public function testAsXml()
     {
         $this->assertSame($this->importer, $this->importer->asXml(), 'The importer supports method chaining');
 
         $this->assertSame('xml', TestHelper::getValue($this->importer, 'asFormat'));
     }
 
-    /**
-     * @testdox  A database drier can be set to the importer
-     */
+    #[TestDox('A database driver can be set to the importer')]
     public function testSetDbo()
     {
-        /** @var DatabaseInterface|MockObject $db */
-        $db = $this->createMock(DatabaseInterface::class);
+        $db = $this->createStub(DatabaseInterface::class);
 
         $this->assertSame($this->importer, $this->importer->setDbo($db), 'The importer supports method chaining');
     }
 
-    /**
-     * @testdox  The importer can be configured to export with structure
-     */
+    #[TestDox('The importer can be configured to export with structure')]
     public function testWithStructure()
     {
         $this->assertSame($this->importer, $this->importer->withStructure(false), 'The importer supports method chaining');