Fix code smells: logging, crash handling, crypto, and build repos - #17
Open
musamakhan201 wants to merge 1 commit into
Open
Fix code smells: logging, crash handling, crypto, and build repos#17musamakhan201 wants to merge 1 commit into
musamakhan201 wants to merge 1 commit into
Conversation
musamakhan201
commented
May 13, 2026
musamakhan201
commented
- Replace printStackTrace with Log across util and app modules.
- CipherUtils: safe MD5 (UTF-8, null guard), deprecate weak DES APIs.
- RebootThreadExceptionHandler: fix toast condition, app context, delegate chain, logging.
- DoubleKeyValueMap: null-safe getAllValues iteration.
- Singleton: volatile double-checked locking.
- BaseCrashHandler: BuildConfig.DEBUG, log failures, interrupt policy.
- ImsiUtil, PhoneUtil, BitmapActivity: remove TODOs; document or log errors.
- AppUtils: DEBUG via Log.isLoggable; LogUtils: drop System.out branches.
- FileUtils: null-safe close in getFileSize; DeviceUtils: fix javadoc.
- build.gradle: add google() and mavenCentral(); app uses project(:util).
- Replace printStackTrace with Log across util and app modules. - CipherUtils: safe MD5 (UTF-8, null guard), deprecate weak DES APIs. - RebootThreadExceptionHandler: fix toast condition, app context, delegate chain, logging. - DoubleKeyValueMap: null-safe getAllValues iteration. - Singleton: volatile double-checked locking. - BaseCrashHandler: BuildConfig.DEBUG, log failures, interrupt policy. - ImsiUtil, PhoneUtil, BitmapActivity: remove TODOs; document or log errors. - AppUtils: DEBUG via Log.isLoggable; LogUtils: drop System.out branches. - FileUtils: null-safe close in getFileSize; DeviceUtils: fix javadoc. - build.gradle: add google() and mavenCentral(); app uses project(:util). Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.