Repository navigation
feat: keep the original error when a promise settles the wrong way - #16484
Open
eduardorittner wants to merge 1 commit into
Open
eduardorittner wants to merge 1 commit into
eduardorittner wants to merge 1 commit into
Conversation
|
|
✅ Deploy Preview for jestjs ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
eduardorittner
force-pushed
the
fix/promise-matcher-cause
branch
from
October 6, 2026 11:54
a505236 to
45ff2dc
Compare
babel-jest
babel-plugin-jest-hoist
babel-preset-jest
create-jest
@jest/diff-sequences
expect
@jest/expect-utils
jest
jest-changed-files
jest-circus
jest-cli
jest-config
@jest/console
@jest/core
@jest/create-cache-key-function
jest-diff
jest-docblock
jest-each
@jest/environment
jest-environment-jsdom
@jest/environment-jsdom-abstract
jest-environment-node
@jest/expect
@jest/fake-timers
@jest/get-type
@jest/globals
jest-haste-map
jest-jasmine2
jest-leak-detector
jest-matcher-utils
jest-message-util
jest-mock
@jest/pattern
jest-phabricator
jest-regex-util
@jest/reporters
jest-resolve
jest-resolve-dependencies
jest-runner
jest-runtime
@jest/schemas
jest-snapshot
@jest/snapshot-utils
@jest/source-map
@jest/test-result
@jest/test-sequencer
@jest/transform
@jest/types
jest-util
jest-validate
jest-watcher
jest-worker
pretty-format
commit: |
eduardorittner
force-pushed
the
fix/promise-matcher-cause
branch
from
October 6, 2026 12:03
45ff2dc to
3bfc1c4
Compare
eduardorittner
force-pushed
the
fix/promise-matcher-cause
branch
from
October 6, 2026 12:13
3bfc1c4 to
70fc4c1
Compare
Author
|
CI failures seem unrelated to my changes, but I can't re-run the failed steps so I can't confirm that |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #14750 by setting
causewhen.resolvesor.rejectsgets the wrong outcome.Test plan
Added tests to AsyncFailures.test.ts which capture the
causeblock in snapshots andmatchers.test.jswhich check thatcauseis correctly populated.Before / after
Before (jest 30.5.2):
After: