Convert from a String in the secret test - #214
Merged
Merged
Conversation
The test for `From<String>` on a secret converted from a `&str`, so it duplicated the test beside it and left the conversion it was named for untested. Removing the implementation from the macro did not break either test. It now converts from a `String`, and removing the implementation fails to compile.
jdno
force-pushed
the
fix-secret-string-conversion
branch
from
August 21, 2026 13:52
55a0650 to
5a02902
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #213, which touches the same tests. GitHub retargets this at
mainonce that one merges.The test for
From<String>on a secret converted from a&str:So it duplicated
from_str_returns_secretbeside it, and the conversion it was named for went untested. It now converts from aString.Notes for review
impl From<String>from thesecret!macro. The test now fails to compile, where before the change neither secret test noticed.tests/secret.rschanges.just pre-commitpasses.