Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The resource label events endpoints (
IssueLabelEvents,MergeRequestLabelEvents,EpicLabelEvents) return"label": nullfor an event whose label has since been deleted:{ "id": 123, "user": { "id": 1, "username": "jane", "...": "..." }, "created_at": "2024-01-29T14:26:49.909+01:00", "resource_type": "Issue", "resource_id": 456, "label": null, "action": "add" }GitLab keeps the event and nullifies its label reference when the label is removed from the project or group, so any long-lived issue or merge request can carry a few of these. Observed on a self-managed GitLab instance.
LabelEventSchematypes the field aslabel: LabelSchema, soevent.label.namecompiles without complaint and throwsTypeError: Cannot read properties of null (reading 'name')at runtime.Change
label: LabelSchema→label: LabelSchema | null.Types only, no runtime change. Nothing inside gitbeaker reads the field. For consumers this surfaces the missing null check at compile time — which is the point, but it does mean code doing
event.label.namewill need a?.after upgrading.