Ensure that the GCOV and GSLC HDF5 dataset noiseEquivalentBackscatter is stored as float32 - #307
Open
gshiroma wants to merge 33 commits into
Open
Ensure that the GCOV and GSLC HDF5 dataset noiseEquivalentBackscatter is stored as float32#307gshiroma wants to merge 33 commits into
gshiroma wants to merge 33 commits into
Conversation
… is stored as float32
… is stored as float32
… is stored as float32
nemo794
reviewed
Aug 20, 2026
nemo794
left a comment
Contributor
There was a problem hiding this comment.
LGTM for the update to the LUT! Thanks!
Quick question before approval: As noted in #305, can you confirm that the statistics attributes (min/max/mean/std/etc) are updated to float32 as well? Do you have a test output from this PR branch? Thanks!
Contributor
Author
Yes |
bhawkins
approved these changes
Aug 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR ensures that the
noiseEquivalentBackscatterdataset in GCOV and GSLC HDF5 files is geocoded and stored asfloat32to match the product specifications.