[MKT-883]feat/Change Price Shown in S3 LP#1947
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
jaaaaavier
requested changes
Jun 25, 2026
jaaaaavier
left a comment
jaaaaavier
left a comment
Contributor
There was a problem hiding this comment.
Why don't you try something similar to what we have at https://github.com/internxt/website/blob/main/src/components/home/components/heroSection/TitleAndOnePlan.tsx
const [currency, setCurrency] = useState(‘€’);
const [currencyValue, setCurrencyValue] = useState(‘eur’);
useEffect(() => {
currencyService.filterCurrencyByCountry().then(({ currency, currencyValue }) => {
setCurrency(currency);
setCurrencyValue(currencyValue);
});
}, []);
What you're proposing could cause re-renders and multiple calls, which might result in performance issues.
| } | ||
|
|
||
| loadCurrency(); | ||
| console.log("el pais es:" + currencyService.getCountry()); |
Contributor
There was a problem hiding this comment.
Never leave console.log statements in your code
|
jaaaaavier
approved these changes
Jun 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
changed shown price for US and Canada users in PriceCardSection using currency.service.