[PB-6516]: fix/add-secure-and-samesite-strict-flags-to-i18next-lang-cookie#2008
Merged
Conversation
sg-gs
changed the title
Deploying drive-web with
|
| Latest commit: |
0979583
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://0a542ed7.drive-web.pages.dev |
| Branch Preview URL: | https://fix-i18next-secure-cookie.drive-web.pages.dev |
…ge cookie The i18next-browser-languagedetector was caching the language preference in a cookie without the Secure flag, allowing it to be sent over HTTP. Adds cookieOptions to the detection config to harden the cookie.
xabg2
reviewed
Jun 25, 2026
| await import('./i18n.service'); | ||
| }); | ||
|
|
||
| it('When initialised, then the language cookie has the Secure flag so it is never sent over HTTP', async () => { |
sg-gs
force-pushed
the
fix/i18next-secure-cookie
branch
from
00a1c17 to
85b5d96
Compare
xabg2
approved these changes
Jun 25, 2026
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The i18next-browser-language detector was caching the language preference in a cookie without the Secure flag, allowing it to be sent over HTTP. Adds cookieOptions to the detection config to harden the cookie.
Related Issues
None
Related Pull Requests
#2007
Checklist
Testing Process
Switch between languages to ensure i18next did not broke.
Additional Notes
Nothing