Skip to content

[PB-6328]: feature/activate Reached File Size Limit Dialog#1983

Open
xabg2 wants to merge 5 commits into
masterfrom
feature/activate-Reach-File-Size-Limit-Dialog
Open

[PB-6328]: feature/activate Reached File Size Limit Dialog#1983
xabg2 wants to merge 5 commits into
masterfrom
feature/activate-Reach-File-Size-Limit-Dialog

Conversation

@xabg2

@xabg2 xabg2 commented Jun 5, 2026

Copy link
Copy Markdown
Contributor

Description

Activating the reached file size limit dialog once the user hits its limit depending on their tier.

Related Issues

Related Pull Requests

Checklist

  • Changes have been tested locally.
  • Unit tests have been written or updated as necessary.
  • The code adheres to the repository's coding standards.
  • Relevant documentation has been added or updated.
  • No new warnings or errors have been introduced.
  • SonarCloud issues have been reviewed and addressed.
  • QA Passed

Testing Process

Additional Notes

@xabg2 xabg2 self-assigned this Jun 5, 2026
@xabg2 xabg2 added the enhancement New feature or request label Jun 5, 2026
@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Jun 5, 2026

Copy link
Copy Markdown

Deploying drive-web with  Cloudflare Pages  Cloudflare Pages

Latest commit: 58f88bb
Status: ✅  Deploy successful!
Preview URL: https://5605ad57.drive-web.pages.dev
Branch Preview URL: https://feature-activate-reach-file.drive-web.pages.dev

View logs

@xabg2 xabg2 marked this pull request as ready for review June 5, 2026 12:54
@xabg2 xabg2 requested review from a team, CandelR and larryrider as code owners June 5, 2026 12:54
sg-gs
sg-gs previously approved these changes Jun 5, 2026

@sg-gs sg-gs left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for cleaning up the upload manager a bit @xabg2

larryrider
larryrider previously approved these changes Jun 5, 2026
import { EnvironmentConfig, IUploadParams } from './types';

export const MAX_ALLOWED_UPLOAD_SIZE = 40 * 1024 * 1024 * 1024;
export const MAX_ALLOWED_UPLOAD_SIZE = 10 * 1024 * 1024 * 1024;

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why this is 10 now?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

because the essential plan has 10 GB (the smaller plan). If a user does not have tier, he should not have a bigger Upload Size Limit.

CandelR
CandelR previously approved these changes Jun 8, 2026
@xabg2 xabg2 dismissed stale reviews from CandelR, larryrider, and sg-gs via 3dfd7a1 June 16, 2026 08:50
@sonarqubecloud

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants