Fix OmnivaProviderTest stub for Savon XML namespace differences#61
Open
mmeest wants to merge 1 commit into
Open
Fix OmnivaProviderTest stub for Savon XML namespace differences#61mmeest wants to merge 1 commit into
mmeest wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Updates the OmnivaProviderTest#test_sends_normalized_e_invoice WebMock stub to match essential SOAP content via regex instead of an exact XML string (authPhrase, E_Invoice).
Why tests were failing
After upgrading CI from Ruby 2.7 to 3.2.2 and switching to a plain bundle install (no Gemfile.lock in the repo), dependency resolution pulled newer Savon/httpi/wasabi versions. The newer Savon build generates a SOAP envelope with fewer XML namespace declarations than the test expected. WebMock compares request bodies exactly, so the stub no longer matched — even though OmnivaProvider logic itself did not change.