Fix issue labeling logic#13145
Merged
Merged
Conversation
for more information, see https://pre-commit.ci
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the GitHub issue comment digest bot’s “should we label this issue as Needs: Response?” decision logic, specifically how bot commenters are handled.
Changes:
- Refactors
should_label_issue()to use a walrus assignment and early return for bot accounts. - Preserves the previous semantics for known bot accounts vs. non-bot commenters (with one noted type-safety concern in review comments).
Comment on lines
+197
to
+198
| if (bot_acct := next((bot for bot in bots if bot["githubUsername"] == last_commenter), None)): | ||
| return bot_acct["triggersNeedsResponse"] |
jimchamp
commented
Jul 10, 2026
jimchamp
commented
Jul 10, 2026
jimchamp
commented
Jul 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follows #13139
Fixes logic for the recently added
should_label_issuefunction.Please squash before merging
Technical
Testing
Screenshot
Stakeholders