Remove redundant superfast feature flag#13100
Merged
RayBB merged 1 commit intoJul 4, 2026
Merged
Conversation
Collaborator
|
Thanks for the PR, @Sanket17052006! Reviewer expectations: A reviewer must first be assigned. There are currently 30 open PRs of equal or higher priority ahead of yours. PR triage checklist (maintainers / Richy)
Note This comment was automatically generated by PAM, Open Library's Project AI Manager. PAM provides status visibility, performs basic project management functions, and gives actionable feedback so contributors aren't left waiting. — Richy, via PAM (Open Library's Project AI Manager) |
github-project-automation
Bot
moved this to Waiting Review/Merge from Staff
in Ray's Project
Collaborator
|
@Sanket17052006 this one has some merge conflicts now. |
Sanket17052006
force-pushed
the
remove-superfast-feature-flag
branch
from
381210e to
5532974
Compare
Contributor
Author
|
Ready to go resolved the conflict! |
github-actions
Bot
added
the
Needs: Response
github-project-automation
Bot
moved this from Waiting Review/Merge from Staff
to Done
in Ray's Project
RayBB
pushed a commit
that referenced
this pull request
Jul 5, 2026
…13122) PR #13094 removed every code reference to the recentchanges_v2 flag (the field in openlibrary/core/features.py, the is_enabled() checks in recentchanges.py, its template usage, and its test) but left the flag's declaration in conf/openlibrary.yml. Nothing reads it anymore, so the entry is dead config. Remove it to finish the cleanup, matching the complete-removal pattern used for the superfast flag in #13100. Part of #12946
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #12946
This PR is made to remove the redundant
superfastfeature flagTechnical
superfastfeature flag which was always enabledpage.prefetch(),page.get_most_recent_change().author, andpage.get_history_preview()Testing
make test-py-uv PYTEST_ARGS="openlibrary/tests/core/test_features.py"superfastremain anywhere in the codebaseScreenshot
N/A
Stakeholders
@RayBB