Skip to content

Remove redundant lists feature flag#13087

Merged
RayBB merged 1 commit into
internetarchive:masterfrom
Sanket17052006:remove-lists-feature-flag
Jul 4, 2026
Merged

Remove redundant lists feature flag#13087
RayBB merged 1 commit into
internetarchive:masterfrom
Sanket17052006:remove-lists-feature-flag

Conversation

@Sanket17052006

Copy link
Copy Markdown
Contributor

Part of #12946

This PR removes the lists feature flag since it's enabled across all environments.

Technical

  • Removed lists: enabled from conf/openlibrary.yml.
  • Removed lists field from pydantic-settings Features model in openlibrary/core/features.py.
  • Removed is_enabled() override from lists class in openlibrary/plugins/openlibrary/lists.py — parent delegate.page defaults to True, matching the always-on behavior.
  • Simplified openlibrary/templates/type/user/view.htmlpage.get_lists(limit=3) now always runs (was already the case in production); the $else: lists = [] dead branch is removed.
  • Simplified openlibrary/templates/lists/widget.html by removing the early return guard.
  • Simplified openlibrary/templates/type/edition/view.html, openlibrary/templates/type/author/view.html, and openlibrary/templates/recentchanges/index.html by removing the "lists" in ctx.features branches.
  • Removed lists from test fixtures in test_features.py.

Testing

  • Ran make test-py-uv PYTEST_ARGS="openlibrary/tests/core/test_features.py"
  • Grepped for "lists" in ctx.features and "lists" in web.ctx.features none remains

Screenshot

N/A

Stakeholders

@RayBB

@openlibrary-bot

Copy link
Copy Markdown
Collaborator

Thanks for the PR, @Sanket17052006!

The linked issue hasn't been triaged yet — triage happens on Mondays and Fridays. There are currently 25 open non-draft PRs ahead of yours.

PR triage checklist (maintainers / Richy)
  • PR description — not empty; explains what the change does and how to verify it
  • References an issue — PR body contains a #NNN reference
    • Linked issue is triaged — has a Priority: * label (not just Needs: Triage)
    • Linked issue is assigned — has at least one assignee
  • Commit history clean — no WIP/fixup/conflict noise; commit messages are meaningful
  • CI passing — no failing check-runs
  • Test cases present — if the change touches substantive logic, test coverage exists or is explained
  • Proof of testing — PR body includes a description of what was tested, a screenshot, or a video

Note

This comment was automatically generated by PAM, Open Library's Project AI Manager. PAM provides status visibility, performs basic project management functions, and gives actionable feedback so contributors aren't left waiting.

@RayBB RayBB self-assigned this Jul 1, 2026
@github-project-automation github-project-automation Bot moved this to Waiting Review/Merge from Staff in Ray's Project Jul 1, 2026
@github-actions github-actions Bot added the Needs: Response Issues which require feedback from lead label Jul 2, 2026
@mekarpeles mekarpeles removed the Needs: Response Issues which require feedback from lead label Jul 4, 2026

@RayBB RayBB left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks good but we have some merge conflicts to resolve.

@github-project-automation github-project-automation Bot moved this from Waiting Review/Merge from Staff to Someone else is working on it in Ray's Project Jul 4, 2026
@Sanket17052006 Sanket17052006 force-pushed the remove-lists-feature-flag branch from 06f2a8a to 6081f43 Compare July 4, 2026 18:39
@Sanket17052006

Copy link
Copy Markdown
Contributor Author

@RayBB Done!

@RayBB RayBB left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this one as well. We're making quick progress on this little project!

@RayBB RayBB merged commit b6462c1 into internetarchive:master Jul 4, 2026
4 checks passed
@github-project-automation github-project-automation Bot moved this from Someone else is working on it to Done in Ray's Project Jul 4, 2026
@Sanket17052006 Sanket17052006 deleted the remove-lists-feature-flag branch July 4, 2026 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants