Remove redundant lists feature flag#13087
Merged
RayBB merged 1 commit intoJul 4, 2026
Merged
Conversation
Collaborator
|
Thanks for the PR, @Sanket17052006! The linked issue hasn't been triaged yet — triage happens on Mondays and Fridays. There are currently 25 open non-draft PRs ahead of yours. PR triage checklist (maintainers / Richy)
Note This comment was automatically generated by PAM, Open Library's Project AI Manager. PAM provides status visibility, performs basic project management functions, and gives actionable feedback so contributors aren't left waiting. |
RayBB
requested changes
Jul 4, 2026
RayBB
left a comment
Collaborator
There was a problem hiding this comment.
Generally looks good but we have some merge conflicts to resolve.
06f2a8a to
6081f43
Compare
Contributor
Author
|
@RayBB Done! |
RayBB
approved these changes
Jul 4, 2026
RayBB
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for this one as well. We're making quick progress on this little project!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #12946
This PR removes the
listsfeature flag since it'senabledacross all environments.Technical
lists: enabledfromconf/openlibrary.yml.listsfield from pydantic-settingsFeaturesmodel inopenlibrary/core/features.py.is_enabled()override fromlistsclass inopenlibrary/plugins/openlibrary/lists.py— parentdelegate.pagedefaults toTrue, matching the always-on behavior.openlibrary/templates/type/user/view.html—page.get_lists(limit=3)now always runs (was already the case in production); the$else: lists = []dead branch is removed.openlibrary/templates/lists/widget.htmlby removing the early return guard.openlibrary/templates/type/edition/view.html,openlibrary/templates/type/author/view.html, andopenlibrary/templates/recentchanges/index.htmlby removing the"lists" in ctx.featuresbranches.listsfrom test fixtures intest_features.py.Testing
make test-py-uv PYTEST_ARGS="openlibrary/tests/core/test_features.py""lists" in ctx.featuresand"lists" in web.ctx.featuresnone remainsScreenshot
N/A
Stakeholders
@RayBB