Enable D4XX frame-sync updates, ISX031 exposure controls/fixes, and supporting documentation refresh - #54
Merged
Conversation
RGB is using MFP1 as frame sync input. Signed-off-by: Khai Wen, Ng <khai.wen.ng@intel.com>
Fix table structure. Signed-off-by: Khai Wen, Ng <khai.wen.ng@intel.com>
Update the sensor list to match current supported configuration. Signed-off-by: Khai Wen, Ng <khai.wen.ng@intel.com>
SSDT ASL method has dependency on I2C_ATR module. Add the section to specify the need to rebuild kernel if the kernel module is missing. Signed-off-by: Khai Wen, Ng <khai.wen.ng@intel.com>
Expose V4L2 controls to switch between automatic and manual exposure on ISX031 and to program the manual exposure time. - add V4L2_CID_EXPOSURE_AUTO to select AEMODE (auto vs. FULL_ME) - add V4L2_CID_EXPOSURE to program the shutter value (SP1 + SP2) in microseconds when in manual mode - activate/deactivate the exposure control based on the selected AE mode and reject AEMODE changes while streaming - read AEMODE and SHTVAL back from the sensor so cached V4L2 values reflect the hardware state Signed-off-by: Sodhi, Vunny <vunny.sodhi@intel.com>
The isx031_write_reg() and isx031_read_reg() helpers serialized multi-byte values in big-endian order, but the ISX031 sensor uses little-endian layout for its multi-byte registers (LSB at the lower address). This is confirmed by the D3 reference driver, which configures its 16-bit and 32-bit regmaps with val_format_endian = REGMAP_ENDIAN_LITTLE, and by this driver's own mode init tables (e.g. H size 1920 written as 0x8AAA=0x80, 0x8AAB=0x07). As a result, every 2- and 4-byte control write reached the sensor with swapped bytes. The most visible symptom was manual exposure: writing 120000 us to FME_SHTVAL (0xABEC, 32-bit) landed as 0xC0D40100, which the sensor clamped to its VMAX-extended maximum of ~266547 us, pinning the frame rate at 3.75 fps regardless of the requested value. Analog/digital gain and white balance gain writes were similarly corrupted but produced changes that could be mistaken for a working path. Switch the transport helpers to little-endian using put_unaligned_le32() and get_unaligned_le32(). This fixes exposure, analog gain, digital gain, WB gains, AE limits, and all multi-byte readbacks in one place. Verified on hardware: exposure=8000 -> 30.00 fps exposure=120000 -> 7.50 fps exposure=260000 -> 3.75 fps Signed-off-by: Sodhi, Vunny <vunny.sodhi@intel.com>
sengguan
approved these changes
Sep 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes