media: Add IPU8 8-camera AR0234 and D457 external frame-sync support - #50
Merged
Conversation
Add DES1, a second MAX96724 deserializer on I2C2/MIPI port 2, with four GMSL channels (CH00..CH03) each carrying a D3 AR0234 camera through a MAX9295A serializer, mirroring the existing DES0 layout. This expands the D3 AR0234 GMSL configuration from one deserializer with two cameras to two deserializers with eight cameras total. Bump the DefinitionBlock OEM revision and update the file header and channel comments to match. Signed-off-by: Goh, Wei Khang1 <wei.khang1.goh@intel.com>
Extend ar0234.json from two sensor entries to eight (ar0234_acpi-1..8) to match the 8x D3 AR0234 GMSL topology. Bump vcCount from 2 to 4 for all entries and update the I2C addresses in each VIDEO_PIXEL_ARRAY videonode to match the new per-channel sensor addressing. Signed-off-by: Goh, Wei Khang1 <wei.khang1.goh@intel.com>
Regenerate AR0234.IPU75XA.xml/.bin with systool 26.31.3.0 (tag 20260406_1900_297): - Switch the raw-only setting's isys output link from packed SINGLE_PL_10_P to unpacked SINGLE_PL_10 to enable unpacked RAW. - Add the missing isys:output -> lbff_Bayer main data input link for the preview/video settings. Signed-off-by: Goh, Wei Khang1 <wei.khang1.goh@intel.com>
Add fwnode property read-back from ASL, and perform register write to D457 FW. Signed-off-by: Khai Wen, Ng <khai.wen.ng@intel.com>
D457 is using MFP0 for external sync, and getting external sync signal from MFP7 of MAX96724. Signed-off-by: Khai Wen, Ng <khai.wen.ng@intel.com>
Remove reset-gpios for d457. RS MIPI driver does not use it. MFP0 was used for Frame Sync instead. Add gmsl-frame-sync-enable into ASL to be read-back by driver. Signed-off-by: Khai Wen, Ng <khai.wen.ng@intel.com>
Add DESCH_SER_RESET_GPIO for Reset GPIO. Add DESCH_SER_FSIN_GPIO for Fsin GPIO. Signed-off-by: Khai Wen, Ng <khai.wen.ng@intel.com>
The LINK_FREQ_VAL indirection added in 898a6a065e ("ipu7: acpi:
isx031 max linq freq") does not work: iasl's preprocessor expands
LINK_FREQ_VAL to the token LINK_FREQ but does not recursively expand
LINK_FREQ further, so the literal identifier ends up in the AML source
and iasl fails with a syntax error, e.g.:
./script/gen_ssdt.sh acpi/ipu7/max96724_d3_isx031.asl
...
Package () { "mipi-img-link-frequencies", Package() { LINK_FREQ } },
Error 6126 - syntax error
Drop the LINK_FREQ_VAL alias and use LINK_FREQ directly, matching the
pattern already used by acpi/ipu6/_des_common_max96724.asl. Callers keep
the same interface ("#define LINK_FREQ <value>" before include,
"#undef LINK_FREQ" after).
When the includer does not provide LINK_FREQ, only default it for the
duration of this include and undef it on the way out, so the default
does not leak to subsequent includes or block a later "#define LINK_FREQ"
in the same translation unit. A LINK_FREQ_DEFAULTED sentinel tracks
whether this include is the one that installed the default.
Signed-off-by: Sodhi, Vunny <vunny.sodhi@intel.com>
Align with robinson bay implementation. Signed-off-by: Khai Wen, Ng <khai.wen.ng@intel.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes