Skip to content

docs: note that tests/smoketest.sh is not run by any CI workflow #715

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
UgaTheDev wants to merge 1 commit into
base: main
Choose a base branch
from
Open

docs: note that tests/smoketest.sh is not run by any CI workflow #715

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/ci.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ In CI, the tests are run with Python 3.11 - 3.13 on Ubuntu and MacOS runners - y

Some smoke tests currently live in the `tests/smoke` directory and are run with [pytest](https://docs.pytest.org/) via [tox](https://tox.wiki/).

There is also a Shell-based smoke test script that can be found at `tests/smoketest.sh`.
There is also a Shell-based smoke test script that can be found at `tests/smoketest.sh`. It is **not currently run by any CI workflow** (`smoke.yaml` only invokes `tox -e py3-smoke`, which points at `tests/smoke/`) — see [#705](https://github.com/instructlab/training/issues/705) for the coverage this script still exercises (flash-attention on/off, Granite on/off, FSDP+LoRA) that the pytest matrix does not.

To run the smoke tests, you can run `tox -e py3-smoke`

Expand Down