Expose onRouteLifecycleStateChanged(Lifecycle.State) API to allow ActivityStoreContext.isRouteStarted() and ActivityStoreContext.isRouteResumed() keep functioning under non-Fragment navigation host (Compose Nav 3). by alexanderbezverhni · Pull Request #515 · instacart/formula

alexanderbezverhni · 2026-06-03T20:00:19Z

No description provided.

…ivityStoreContext.isRouteStarted() and ActivityStoreContext.isRouteResumed() keep functioning under non-Fragment navigation host (Compose Nav 3).

olive-agent

formula-android/src/main/java/com/instacart/formula/android/internal/ActivityManager.kt:77

ActivityStoreContextImpl now keeps route lifecycle state until a route reports DESTROYED, but ActivityManager is reused across configuration changes via AppManager. In the non-Fragment host path, there is no automatic equivalent of NavigationFlowRenderView.onFragmentViewDestroyed(), so on activity recreation this delegate can retain stale STARTED/RESUMED entries from the previous activity instance. That means isRouteStarted() / isRouteResumed() can replay true for routes that no longer exist until the new host explicitly re-drives every route. Should we clear the stored route lifecycle state here on activity destroy, or otherwise prove recreation is handled correctly for the new API?

carrotkite · 2026-06-03T20:05:46Z

JaCoCo Code Coverage 93.83% ✅

Class	Covered	Meta	Status
`com/instacart/formula/android/NavigationStore`	83%	0%	✅
`com/instacart/formula/android/internal/ActivityManager`	50%	0%	✅
`com/instacart/formula/android/internal/ActivityStoreContextImpl`	100%	0%	✅

Generated by 🚫 Danger

carrotkite · 2026-06-03T20:09:35Z

📊 Benchmark Comparison Report

Summary

Regressions: 0 ✅
Improvements: 21 🎉
Unchanged: 4

🎉 Performance Improvements

Benchmark	Baseline	Current	Change
com.instacart.formula.benchmarks.TransitionQueueBenchmark.measure1	0.486 ± 0.003 us/op	0.318 ± 0.004 us/op	-34.5% 🟢
com.instacart.formula.benchmarks.TransitionQueueBenchmark.measure100	0.488 ± 0.007 us/op	0.323 ± 0.008 us/op	-33.9% 🟢
com.instacart.formula.benchmarks.TransitionQueueBenchmark.measure10000	0.492 ± 0.003 us/op	0.336 ± 0.003 us/op	-31.7% 🟢
com.instacart.formula.benchmarks.ChildrenInitializationBenchmark.initializeNewChildren (childrenCount=1)	0.857 ± 0.09 us/op	0.613 ± 0.046 us/op	-28.5% 🟢
com.instacart.formula.benchmarks.GlobalEffectQueueBenchmark.measure100Effects	10.835 ± 0.417 us/op	7.924 ± 0.397 us/op	-26.9% 🟢
com.instacart.formula.benchmarks.ActionInitializationBenchmark.initializeNewActions (actionCount=1)	0.832 ± 0.026 us/op	0.63 ± 0.045 us/op	-24.3% 🟢
com.instacart.formula.benchmarks.TransitionBenchmark.transitions (depth=0)	15.237 ± 0.076 us/op	11.551 ± 0.174 us/op	-24.2% 🟢
com.instacart.formula.benchmarks.TransitionBenchmark.transitions (depth=10)	15.537 ± 0.081 us/op	11.786 ± 0.06 us/op	-24.1% 🟢
com.instacart.formula.benchmarks.ActionCountBenchmark.stateChanges (actionCount=1)	15.31 ± 0.081 us/op	11.632 ± 0.065 us/op	-24.0% 🟢
com.instacart.formula.benchmarks.CallbackOverheadBenchmark.transitions (callbackCount=50)	17.927 ± 1.928 us/op	13.66 ± 0.373 us/op	-23.8% 🟢
com.instacart.formula.benchmarks.ChildrenCountBenchmark.stateChanges (childrenCount=1)	15.29 ± 0.191 us/op	11.653 ± 0.154 us/op	-23.8% 🟢
com.instacart.formula.benchmarks.CallbackOverheadBenchmark.transitions (callbackCount=10)	15.69 ± 0.14 us/op	12.017 ± 0.098 us/op	-23.4% 🟢
com.instacart.formula.benchmarks.ChildrenCountBenchmark.stateChanges (childrenCount=25)	15.787 ± 0.142 us/op	12.113 ± 0.05 us/op	-23.3% 🟢
com.instacart.formula.benchmarks.ActionCountBenchmark.stateChanges (actionCount=25)	15.582 ± 0.175 us/op	11.965 ± 0.044 us/op	-23.2% 🟢
com.instacart.formula.benchmarks.CallbackInitializationBenchmark.initializeNewCallbacks (callbackCount=10)	1.994 ± 0.184 us/op	1.533 ± 0.246 us/op	-23.1% 🟢
com.instacart.formula.benchmarks.TransitionBenchmark.transitions (depth=20)	15.934 ± 0.108 us/op	12.319 ± 0.09 us/op	-22.7% 🟢
com.instacart.formula.benchmarks.CallbackInitializationBenchmark.initializeNewCallbacks (callbackCount=50)	7.279 ± 1.991 us/op	5.639 ± 0.62 us/op	-22.5% 🟢
com.instacart.formula.benchmarks.ActionCountBenchmark.stateChanges (actionCount=100)	16.764 ± 0.17 us/op	12.988 ± 0.114 us/op	-22.5% 🟢
com.instacart.formula.benchmarks.ChildrenCountBenchmark.stateChanges (childrenCount=100)	17.345 ± 0.087 us/op	13.614 ± 0.077 us/op	-21.5% 🟢
com.instacart.formula.benchmarks.ActionInitializationBenchmark.initializeNewActions (actionCount=25)	3.881 ± 0.063 us/op	3.18 ± 0.076 us/op	-18.1% 🟢
com.instacart.formula.benchmarks.ChildrenInitializationBenchmark.initializeNewChildren (childrenCount=25)	3.922 ± 0.072 us/op	3.41 ± 0.059 us/op	-13.1% 🟢

No significant changes (4 benchmarks)

Benchmark	Baseline	Current	Change
com.instacart.formula.benchmarks.ActionInitializationBenchmark.initializeNewActions (actionCount=100)	12.411 ± 0.142 us/op	11.288 ± 0.024 us/op	-9.1%
com.instacart.formula.benchmarks.ChildrenInitializationBenchmark.initializeNewChildren (childrenCount=100)	13.15 ± 0.185 us/op	12.238 ± 0.08 us/op	-6.9%
com.instacart.formula.benchmarks.GlobalEffectQueueBenchmark.measure10Effects	0.764 ± 0.008 us/op	0.696 ± 0.005 us/op	-8.8%
com.instacart.formula.benchmarks.GlobalEffectQueueBenchmark.measure1Effect	0.06 ± 0.001 us/op	0.056 ± 0.001 us/op	-6.5%

Regressions: ±10% with non-overlapping confidence intervals. Improvements: ±10% change only.

Generated by 🚫 Danger

alexanderbezverhni · 2026-06-03T20:56:47Z

formula-android/src/main/java/com/instacart/formula/android/internal/ActivityManager.kt:77

ActivityStoreContextImpl now keeps route lifecycle state until a route reports DESTROYED, but ActivityManager is reused across configuration changes via AppManager. In the non-Fragment host path, there is no automatic equivalent of NavigationFlowRenderView.onFragmentViewDestroyed(), so on activity recreation this delegate can retain stale STARTED/RESUMED entries from the previous activity instance. That means isRouteStarted() / isRouteResumed() can replay true for routes that no longer exist until the new host explicitly re-drives every route. Should we clear the stored route lifecycle state here on activity destroy, or otherwise prove recreation is handled correctly for the new API?

Good catch - was addressed.

alexanderbezverhni · 2026-06-03T20:57:19Z

    private var activity: Activity? = null
    private var hasStarted: Boolean = false
-    private val fragmentLifecycleStates = mutableMapOf<String, Lifecycle.State>()
+    private val routeLifecycleStates = mutableMapOf<String, Lifecycle.State>()


few fragment -> route renames while I'm here

alexanderbezverhni · 2026-06-03T20:58:20Z

    fun attachActivity(activity: Activity) {
        hasStarted = false
        this.activity = activity
+        clearRouteLifecycleState()


Clearing on new Activity attach rather than on old Activity detach - to cover races when detach happens after attach.

alexanderbezverhni · 2026-06-03T20:59:23Z

+    @MainThread
+    fun onRouteLifecycleStateChanged(routeId: RouteId<*>, state: Lifecycle.State) {
+        onRouteLifecycleState?.invoke(routeId, state)
+    }


New public API for non-Fragment navigation hosts.

alexanderbezverhni · 2026-06-03T21:00:15Z

-import kotlinx.coroutines.rx3.asObservable
+import kotlinx.coroutines.test.runTest


Removing redundant Flow->Observable conversion and switching to turbine tests.

pr-inbox-app · 2026-06-03T21:00:51Z

🚀 Ready for Review? 🚀

Mark your PR as ready and automatically assign the right reviewers.

_{^{Let reviewers know this PR is ready for review}}

Laimiux · 2026-06-08T14:09:49Z

+     * is reused across configuration changes (see [AppManager]), without this the delegate would
+     * retain stale STARTED/RESUMED entries from the previous activity instance.
+     */
+    fun clearRouteLifecycleState() {


I'm not a fan of this logic - I worry it might break fragment logic in an unintuitive way.

Expose onRouteLifecycleStateChanged(Lifecycle.State) API to allow Act…

fe19ad7

…ivityStoreContext.isRouteStarted() and ActivityStoreContext.isRouteResumed() keep functioning under non-Fragment navigation host (Compose Nav 3).

alexanderbezverhni self-assigned this Jun 3, 2026

olive-agent Bot reviewed Jun 3, 2026

View reviewed changes

olive-agent Bot added the reviewed-by-olive label Jun 3, 2026

alexanderbezverhni added 2 commits June 3, 2026 13:18

Test flows.

b3fc061

Clear on Activity re-creation.

79f6476

alexanderbezverhni commented Jun 3, 2026

View reviewed changes

alexanderbezverhni marked this pull request as ready for review June 3, 2026 21:00

alexanderbezverhni requested a review from Laimiux June 3, 2026 21:00

Laimiux reviewed Jun 8, 2026

View reviewed changes

alexanderbezverhni closed this Jun 8, 2026

alexanderbezverhni deleted the bezverhni/fragment_lifecycle branch June 8, 2026 22:36

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Expose onRouteLifecycleStateChanged(Lifecycle.State) API to allow ActivityStoreContext.isRouteStarted() and ActivityStoreContext.isRouteResumed() keep functioning under non-Fragment navigation host (Compose Nav 3).#515

alexanderbezverhni commented Jun 3, 2026

Uh oh!

olive-agent Bot left a comment

Uh oh!

carrotkite commented Jun 3, 2026 •

edited

Loading

Uh oh!

carrotkite commented Jun 3, 2026 •

edited

Loading

Uh oh!

alexanderbezverhni commented Jun 3, 2026

Uh oh!

alexanderbezverhni Jun 3, 2026

Uh oh!

alexanderbezverhni Jun 3, 2026

Uh oh!

alexanderbezverhni Jun 3, 2026

Uh oh!

alexanderbezverhni Jun 3, 2026

Uh oh!

pr-inbox-app Bot commented Jun 3, 2026

🚀 Ready for Review? 🚀

Uh oh!

Laimiux Jun 8, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

		import kotlinx.coroutines.rx3.asObservable
		import kotlinx.coroutines.test.runTest

Uh oh!

Conversation

alexanderbezverhni commented Jun 3, 2026

Uh oh!

olive-agent Bot left a comment

Choose a reason for hiding this comment

Uh oh!

carrotkite commented Jun 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

JaCoCo Code Coverage 93.83% ✅

Uh oh!

carrotkite commented Jun 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📊 Benchmark Comparison Report

Summary

🎉 Performance Improvements

Uh oh!

alexanderbezverhni commented Jun 3, 2026

Uh oh!

alexanderbezverhni Jun 3, 2026

Choose a reason for hiding this comment

Uh oh!

alexanderbezverhni Jun 3, 2026

Choose a reason for hiding this comment

Uh oh!

alexanderbezverhni Jun 3, 2026

Choose a reason for hiding this comment

Uh oh!

alexanderbezverhni Jun 3, 2026

Choose a reason for hiding this comment

Uh oh!

pr-inbox-app Bot commented Jun 3, 2026

🚀 Ready for Review? 🚀

Uh oh!

Laimiux Jun 8, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

carrotkite commented Jun 3, 2026 •

edited

Loading

carrotkite commented Jun 3, 2026 •

edited

Loading